Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update @bbc/gel-foundations in all psammead packages #677

Merged
merged 11 commits into from
Jun 25, 2019
Merged

Update @bbc/gel-foundations in all psammead packages #677

merged 11 commits into from
Jun 25, 2019

Conversation

j-pendlebury
Copy link
Contributor

@j-pendlebury j-pendlebury commented Jun 21, 2019 •
edited
Loading

Resolves #673

Overall change: Updates all packages to require @bbc/gel-foundations@3.0.0

Code changes:

  • Updated version of gel-foundations in all package.json's
  • Updated version of gel-foundations in all package-lock's
  • Updated Snapshots
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@j-pendlebury j-pendlebury self-assigned this Jun 21, 2019
@j-pendlebury j-pendlebury added ws-home Tasks for the WS Home Team ws-articles Tasks for the WS Articles Team labels Jun 21, 2019
@j-pendlebury
Copy link
Contributor Author

j-pendlebury commented Jun 21, 2019 •
edited
Loading

Packages Updated:

Components

  • psammead-brand
  • psammead-copyright
  • psammead-figure
  • psammead-headings
  • psammead-media-indicator
  • psammead-paragraph
  • psammead-section-label
  • psammead-sitewide-links
  • psammead-story-promo
  • psammead-story-promo-list
  • psammead-timestamp

Containers

  • psammead-timestamp-container

Utilities

  • psammead-storybook-helpers
  • psammead-styles

@j-pendlebury j-pendlebury force-pushed the update-gel-foundations branch from 9061391 to c93dd56 Compare June 24, 2019 10:28
@j-pendlebury j-pendlebury marked this pull request as ready for review June 24, 2019 10:53
DenisHdz
DenisHdz approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏻

@j-pendlebury j-pendlebury force-pushed the update-gel-foundations branch from 8dab004 to 2185bd4 Compare June 24, 2019 15:32
dr3
dr3 suggested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psammead-inline-link/package-lock.json and packages/components/psammead-visually-hidden-text/package-lock.json have been changed without package.json or changelog changes, can you reset these please?

@j-pendlebury
Copy link
Contributor Author

@dr3 fixed

dr3
dr3 approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staylos92 staylos92 self-assigned this Jun 25, 2019
@staylos92
Copy link
Contributor

LGTM 👍

@j-pendlebury j-pendlebury merged commit b30967d into latest Jun 25, 2019
@j-pendlebury j-pendlebury deleted the update-gel-foundations branch June 25, 2019 11:49
@jroebu14 jroebu14 mentioned this pull request Jul 10, 2019
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DenisHdz DenisHdz DenisHdz approved these changes

@dr3 dr3 dr3 approved these changes

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@staylos92 staylos92

@j-pendlebury j-pendlebury

Labels
high priority ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump @bbc/gel-foundations to latest in all packages
4 participants
@j-pendlebury @staylos92 @dr3 @DenisHdz