This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add Link to Story Promo #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
j-pendlebury
previously approved these changes
May 10, 2019
DenisHdz
added
a11y-swarm
greenc05
reviewed
May 13, 2019
DenisHdz
removed
the
a11y-swarm
j-pendlebury
previously approved these changes
May 15, 2019
ghost
reviewed
May 16, 2019
|
Update |
pjlee11
reviewed
May 17, 2019
| @@ -33,6 +33,8 @@ const eightOfTwelveColumnsMaxScaleable = `66.67%`; | |||
| // (8 / 12) * 100 = 66.6666666667 = 66.67% | |||
|
|
|||
| const StoryPromoWrapper = styled.div` | |||
| position: relative; | |||
There was a problem hiding this comment.
What's the reason this is needed for?
There was a problem hiding this comment.
Ahhh is it part of faux block link?
There was a problem hiding this comment.
That is used to make the faux block link pattern work. If you don't apply it the clickable area is everything and not just the StoryPromoWrapper.
|
LGTM. Happy for this to be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #475 and #519
Overall change:
Add Link to the Story Promo component.
Code changes:
Linkstyled componentfocus,hoverandvisitedstatesfaux block linkpattern to make the entireStoryPromoa link