This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
enable style overrides in timestamp #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2020 13:14
Bump package versions for psammead-timestamp, psammead-timestamp-container
Updates changelogs for psammead-timestamp, psammead-timestamp-container
jroebu14
added
the
cross-team
chris-hinds
approved these changes
Dec 9, 2020
ryanmccombe
reviewed
Dec 9, 2020
| @@ -34,6 +34,7 @@ const Timestamp = ({ | |||
| padding, | |||
| service, | |||
| darkMode, | |||
| className, | |||
| }) => ( | |||
| <StyledTimestamp | |||
There was a problem hiding this comment.
This component seems to be unnecessary - it's just drilling props untouched
I think deleting line 29-49 and just exporting the StyledTimestamp directly might be better
There was a problem hiding this comment.
untouched
Not entirely - it's renaming datetime to dateTime
ryanmccombe
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Enables style overrides on the time element.
Code changes:
classNameprop to timestamp container and timestamp component so that consumers can override styles.