Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Replace instances of BBC Nassim with BBC Reith Qalam #4002

Merged
merged 15 commits into from
Nov 23, 2020
Merged

Replace instances of BBC Nassim with BBC Reith Qalam #4002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5cb4b4d
Add BBC Reith Qalam font-face rules
simonsinclair Nov 17, 2020
ce69044
Bump major package version
simonsinclair Nov 18, 2020
e189995
Add changelog entry
simonsinclair Nov 18, 2020
370f817
Replace BBC Nassim font-families with BBC Reith Qalam's
simonsinclair Nov 18, 2020
0d62915
Remove BBC Nassim font-face rules
simonsinclair Nov 18, 2020
59afb73
Update fonts snapshots
simonsinclair Nov 18, 2020
f4f049a
Update font-styles snapshots
simonsinclair Nov 18, 2020
a66e120
Update font-families snapshots
simonsinclair Nov 18, 2020
6b7b079
Update packages/utilities/psammead-styles/CHANGELOG.md
simonsinclair Nov 18, 2020
7cebb56
Replace BBC Nassim with BBC Reith Qalam in parent test
simonsinclair Nov 18, 2020
92b8dd8
Merge branch 'qalam-styles' of https://github.com/bbc/psammead into q…
simonsinclair Nov 18, 2020
89e4943
Merge branch 'latest' into qalam-styles
karinathomasbbc Nov 18, 2020
3ab9a64
Merge branch 'latest' into qalam-styles
simonsinclair Nov 19, 2020
56ca472
Merge branch 'latest' into qalam-styles
karinathomasbbc Nov 19, 2020
ef26c48
Merge branch 'latest' into qalam-styles
simonsinclair Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/utilities/psammead-styles/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 7.0.0 | [PR#4002](https://github.com/bbc/psammead/pull/4002) Replace BBC Nassim with BBC Reith Qalam. |
| 6.1.0 | [PR#3942](https://github.com/bbc/psammead/pull/3942) Move @font-face declarations outside of html selector. |
| 6.0.1 | [PR#3924](https://github.com/bbc/psammead/pull/3924) Migrate Storybook to Emotion. |
| 6.0.0 | [PR#3880](https://github.com/bbc/psammead/pull/3880) Migrate to Emotion. |
Expand Down
10 changes: 2 additions & 8 deletions packages/utilities/psammead-styles/index.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,8 @@ const fontsExpectedExports = {
F_REITH_SANS_EXTRA_BOLD_ITALIC: 'function',
F_REITH_SANS_CONDENSED_REGULAR: 'function',
F_REITH_SANS_CONDENSED_BOLD: 'function',
F_NASSIM_ARABIC_REGULAR: 'function',
F_NASSIM_ARABIC_BOLD: 'function',
F_NASSIM_PASHTO_REGULAR: 'function',
F_NASSIM_PASHTO_BOLD: 'function',
F_NASSIM_PERSIAN_REGULAR: 'function',
F_NASSIM_PERSIAN_BOLD: 'function',
F_NASSIM_URDU_REGULAR: 'function',
F_NASSIM_URDU_BOLD: 'function',
F_REITH_QALAM_REGULAR: 'function',
F_REITH_QALAM_BOLD: 'function',
F_ISKOOLA_POTA_BBC_REGULAR: 'function',
F_ISKOOLA_POTA_BBC_BOLD: 'function',
F_LATHA_REGULAR: 'function',
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/psammead-styles/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utilities/psammead-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-styles",
"version": "6.1.0",
"version": "7.0.0",
"description": "A collection of string constants for use in CSS, containing non-GEL styling details that are bespoke to specific BBC services and products.",
"repository": {
"type": "git",
Expand Down
16 changes: 8 additions & 8 deletions packages/utilities/psammead-styles/src/__snapshots__/font-families.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ Object {
exports[`Psammead Styles - Font Families should match arabic 1`] = `
Object {
"sansBold": "
font-family: \\"BBC Nassim Arabic\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 700;
font-style: normal;
",
"sansRegular": "
font-family: \\"BBC Nassim Arabic\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 400;
font-style: normal;
",
Expand Down Expand Up @@ -713,12 +713,12 @@ Object {
exports[`Psammead Styles - Font Families should match pashto 1`] = `
Object {
"sansBold": "
font-family: \\"BBC Nassim Pashto\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 700;
font-style: normal;
",
"sansRegular": "
font-family: \\"BBC Nassim Pashto\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 400;
font-style: normal;
",
Expand All @@ -728,12 +728,12 @@ Object {
exports[`Psammead Styles - Font Families should match persian 1`] = `
Object {
"sansBold": "
font-family: \\"BBC Nassim Persian\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 700;
font-style: normal;
",
"sansRegular": "
font-family: \\"BBC Nassim Persian\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 400;
font-style: normal;
",
Expand Down Expand Up @@ -1193,12 +1193,12 @@ Object {
exports[`Psammead Styles - Font Families should match urdu 1`] = `
Object {
"sansBold": "
font-family: \\"BBC Nassim Urdu\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 700;
font-style: normal;
",
"sansRegular": "
font-family: \\"BBC Nassim Urdu\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-family: \\"BBC Reith Qalam\\", Arial, Verdana, Geneva, Helvetica, sans-serif;
font-weight: 400;
font-style: normal;
",
Expand Down
Loading