Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Conditionally apply z-index change to psammead-media-player based on whether the loadingImage is being used #3640

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Conditionally apply z-index change to psammead-media-player based on whether the loadingImage is being used #3640

merged 4 commits into from
Jul 30, 2020

Conversation

RichardPK
Copy link
Contributor

Resolves #bbc/simorgh#7185

Overall change:

  • Wrap z-index change to psammead-media-player in ternary based on whether the loadingImage prop is passed.
  • Bumping version numbers and updating snapshots
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK self-assigned this Jul 30, 2020
@RichardPK RichardPK added the ws-media The World Service media stream label Jul 30, 2020
@RichardPK RichardPK mentioned this pull request Jul 30, 2020
Merged
6 tasks
@RichardPK RichardPK merged commit 1d9f461 into latest Jul 30, 2020
@RichardPK RichardPK deleted the conditionally-apply-z-index-media-player branch July 30, 2020 13:42
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jul 30, 2020
Closed
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Aug 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@rebeccamcginn rebeccamcginn rebeccamcginn approved these changes

Assignees

@RichardPK RichardPK

Labels
ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardPK @ryanmccombe @rebeccamcginn