This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
psammead-storybook-helper - add timezone to withServicesKnob helper #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
force-pushed
the
timezone-storybook-helper
branch
from
aeb7f3a to
287eaef
Compare
sareh
commented
Apr 15, 2020
sareh
commented
Apr 15, 2020
| @@ -34,6 +34,7 @@ export default ({ | |||
| script, | |||
| locale, | |||
| dir = 'ltr', | |||
| timezone = 'GMT', | |||
There was a problem hiding this comment.
Setting a default timezone of 'GMT' since this is used when there is no clearly defined timezone for the service.
3 tasks
1 task
EinsteinNjoroge
approved these changes
Apr 15, 2020
|
Looks like storybook/chromatic is broken |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3358
This is needed to enable correct timezones in Storybook for the Radio Schedules component (PR #3377).
Overall change: Makes timezones available to Storybook knobs.
Note that the timezones added were obtained from the Simorgh Service Config files: e.g. for Afaan Oromoo
Code changes: