Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Remove alpha tag from Radio Schedules component #3350

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Remove alpha tag from Radio Schedules component #3350

merged 4 commits into from
Apr 8, 2020

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Apr 8, 2020 •
edited
Loading

Resolves #2993

Overall change:
After carried out an Accessibility Swarm for the RadioSchedules component and fixed all the bugs, we can move forward and remove the alpha tag from the component.

Code changes:

  • Remove alpha tag from the package.json
  • Bump package to a stable version
  • Remove alpha text from README
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added ws-home Tasks for the WS Home Team radio-schedules labels Apr 8, 2020
@DenisHdz DenisHdz self-assigned this Apr 8, 2020
OlgaLyubin
OlgaLyubin reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version in package.json should be updated too

@DenisHdz
Copy link
Contributor Author

DenisHdz commented Apr 8, 2020

Version in package.json should be updated too

Thought I did 🙈

OlgaLyubin
OlgaLyubin reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this Readme section too?

Screenshot 2020-04-08 at 12 47 08

OlgaLyubin
OlgaLyubin approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 👍

Bopchy
Bopchy approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@Bopchy Bopchy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@DenisHdz DenisHdz merged commit 7c29b89 into latest Apr 8, 2020
@DenisHdz DenisHdz deleted the remove-alpha-radio-schedules branch April 8, 2020 12:59
This was referenced Apr 8, 2020
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bopchy Bopchy Bopchy approved these changes

@OlgaLyubin OlgaLyubin OlgaLyubin approved these changes

Assignees

@DenisHdz DenisHdz

Labels
radio-schedules ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove alpha tag from Radio Schedules component
3 participants
@DenisHdz @Bopchy @OlgaLyubin