This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Invalid HTML bug in section label #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaLyubin
commented
Apr 2, 2020
OlgaLyubin
commented
Apr 2, 2020
DenisHdz
reviewed
Apr 3, 2020
| @@ -23,7 +23,7 @@ const paddingReverseDir = ({ dir }) => | |||
| // This makes it work right. I don't fully understand how, but am | |||
| // eternally grateful to the Flexbugs project. | |||
| // https://github.com/philipwalton/flexbugs#flexbug-3 | |||
| const FlexColumn = styled.div` | |||
| const FlexColumn = styled.span` | |||
There was a problem hiding this comment.
Can you check if we really need this FlexColumn or if we could try to merge it along with FlexRow, so we avoid having that many nested spans?
There was a problem hiding this comment.
If we remove FlexColumn or merge it with FlexRow everything still looks great on Chrome, FireFox and Safari. However, it causes the bar to get shifted down on Internet Explorer. And even though IE is a low priority browser for us, section labels are on every front page, so I don't think it's worth making this change just to avoid having a lot of spans in the DOM.
There was a problem hiding this comment.
All right, thanks for investing though :)
j-pendlebury
approved these changes
Apr 3, 2020
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3316
Overall change:
Replaced a
divwith aspanwithin section label to fix invalid HTML syntax (divnested within anh2element).New DOM structure:
Code changes:
divwith aspanin section label.