Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix FireFox High Contrast Mode for Radio Schedule #3324

Merged
merged 12 commits into from
Apr 6, 2020

Conversation

OlgaLyubin
Copy link
Contributor

Resolves #3323

Overall change:
Made duration border display in FireFox High Contrast Mode.
The reason why outline is used instead of border-top is because during Radio Schedule accessibility swarm UX mentioned that there should be no extra border around the duration button (even if it's invisible) because it adds height.

Before:
Screenshot 2020-04-01 at 11 06 46

After:
Screenshot 2020-04-01 at 11 06 34

Code changes:

  • Added outline to duration button.
  • Updated snapshots.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@OlgaLyubin OlgaLyubin added ws-home Tasks for the WS Home Team radio-schedules labels Apr 1, 2020
@OlgaLyubin OlgaLyubin self-assigned this Apr 1, 2020
Bopchy
Bopchy previously approved these changes Apr 1, 2020
Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out in FF and it looks great, however it overrides the transparent border on the Button in IE.

Screenshot 2020-04-01 at 18 07 03

Should confirm whether this is a major concern though

@Bopchy Bopchy dismissed their stale review April 1, 2020 15:11

Noted an issue in IE11

@OlgaLyubin
Copy link
Contributor Author

OlgaLyubin commented Apr 3, 2020

Fixed so that IE high contrast mode looks like this:
Screenshot 2020-04-03 at 10 09 50

Still not ideal, but since IE is a low priority browser, it can stay like this.

@PriyaKR PriyaKR self-assigned this Apr 3, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Apr 3, 2020

Looks good to me on FF.
Screenshot 2020-04-03 at 16 00 40

Looks as described by Olga on IE11.
VirtualBox_MSEdge - Win10_03_04_2020_17_52_19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
radio-schedules ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio Schedule: FireFox high contrast border bug
4 participants