Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

LiveLabel - remove withOffScreenText prop #3276

Merged
merged 2 commits into from
Mar 19, 2020
Merged

LiveLabel - remove withOffScreenText prop #3276

merged 2 commits into from
Mar 19, 2020

Conversation

DenisHdz
Copy link
Contributor

Resolves #NUMBER

Overall change:

  • Remove the boolean withOffScreenText prop and use the offScreenText prop to determine if it should also include offscreen text or not.

Code changes:

  • Remove withOffScreenText references
  • Set offScreenText default to null
  • Update stories
  • Update tests
  • Update README
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Mar 19, 2020
@DenisHdz DenisHdz self-assigned this Mar 19, 2020
thekp
thekp approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenisHdz DenisHdz merged commit da7ee47 into latest Mar 19, 2020
@DenisHdz DenisHdz deleted the remove-withoffscreen-live-label branch March 19, 2020 14:58
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thekp thekp thekp approved these changes

@tochwill tochwill tochwill approved these changes

Assignees

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenisHdz @tochwill @thekp