This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Move to storybook 5 #323
Merged
Merged
Move to storybook 5 #323
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7399740
:rocket: Move to storybook 5
d6bb4e0
:rocket: Update readme format
2dd2cdd
:rocket: Linting
c9bd758
:rocket: Dont need to update this
3643b4e
:rocket: Package lock
3caddcc
:wrench: Package lock
bea3379
:rocket: Disable no-extraneous-dependencies as it never worked
3b24543
Pull latest
2d1b05d
Merge branch 'latest' into Storybook5
060266c
:rocket: Update deprecated value
32f9694
:rocket: Add theme to retain psammead branding
156ce1c
Damn spelling
9d031f8
:wrench: Remove sortStoriesByKind
0fda001
:rocket: Clean up readme calls
c42db38
:bath: Clean up missed converts
8b288ac
:rocket: Update readmes
0179b71
Apply suggestions from code review
sareh 763c583
Update packages/components/psammead-sitewide-links/package-lock.json
sareh 85cb247
Pull latest and de-conflict
05dc39b
Merge branch 'latest' into Storybook5
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| import 'storybook-readme/register'; | ||
| import '@storybook/addon-options/register'; | ||
| import '@storybook/addon-notes/register'; | ||
| import '@storybook/addon-knobs/register'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import React from 'react'; | ||
dr3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| import { storiesOf } from '@storybook/react'; | ||
| import { withReadme } from 'storybook-readme'; | ||
| import Readme from '../README.md'; | ||
| import notes from '../README.md'; | ||
| import Brand from './index'; | ||
|
|
||
| storiesOf('Brand', module) | ||
| .addDecorator(withReadme(Readme)) | ||
| .add('default', () => <Brand brandName="Default Brand Name" />); | ||
| storiesOf('Brand', module).add( | ||
| 'default', | ||
| () => <Brand brandName="Default Brand Name" />, | ||
| { notes }, | ||
| ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 6 additions & 5 deletions
11
packages/components/psammead-copyright/src/index.stories.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import React from 'react'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { withReadme } from 'storybook-readme'; | ||
| import Readme from '../README.md'; | ||
| import notes from '../README.md'; | ||
| import Copyright from './index'; | ||
|
|
||
| storiesOf('Copyright', module) | ||
| .addDecorator(withReadme(Readme)) | ||
| .add('default', () => <Copyright>Getty Images</Copyright>); | ||
| storiesOf('Copyright', module).add( | ||
| 'default', | ||
| () => <Copyright>Getty Images</Copyright>, | ||
| { notes }, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,20 @@ | ||
| import React from 'react'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { withReadme } from 'storybook-readme'; | ||
| import Image from '@bbc/psammead-image'; | ||
| import Readme from '../README.md'; | ||
| import notes from '../README.md'; | ||
| import Figure from '.'; | ||
|
|
||
| const imageAlt = | ||
| 'Map of the UK displaying Syrian refugees and asylum seekers per 10000 population. Ranges from 0 to 17.'; | ||
| const imageSrc = | ||
| 'https://ichef.bbci.co.uk/news/640/cpsprodpb/439A/production/_100960371_syrians_and_asylum_v2-nc.png'; | ||
| const imageWidth = 853; | ||
| storiesOf('Figure', module) | ||
| .addDecorator(withReadme(Readme)) | ||
| .add('containing Image', () => ( | ||
| storiesOf('Figure', module).add( | ||
| 'containing Image', | ||
| () => ( | ||
| <Figure> | ||
| <Image alt={imageAlt} src={imageSrc} width={imageWidth} /> | ||
| </Figure> | ||
| )); | ||
| ), | ||
| { notes }, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 12 additions & 9 deletions
21
packages/components/psammead-headings/src/index.stories.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| import React from 'react'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { withReadme } from 'storybook-readme'; | ||
| import Readme from '../README.md'; | ||
| import notes from '../README.md'; | ||
| import { Headline, SubHeading } from './index'; | ||
|
|
||
| storiesOf('Headline', module) | ||
| .addDecorator(withReadme(Readme)) | ||
| .add('default', () => <Headline>This is my headline.</Headline>); | ||
| storiesOf('Headline', module).add( | ||
| 'default', | ||
| () => <Headline>This is my headline.</Headline>, | ||
| { notes }, | ||
| ); | ||
|
|
||
| storiesOf('SubHeading', module) | ||
| .addDecorator(withReadme(Readme)) | ||
| .add('default', () => ( | ||
| storiesOf('SubHeading', module).add( | ||
| 'default', | ||
| () => ( | ||
| <SubHeading text="This is a SubHeading">This is a SubHeading</SubHeading> | ||
| )); | ||
| ), | ||
| { notes }, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/components/psammead-image-placeholder/package-lock.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this as without it you lose the word 'Psammead' from the top left