Update bulletin to use new version of live label from story promo #3208
Conversation
|
Just fixing package lock issues |
| "@bbc/psammead-visually-hidden-text": "^1.2.3", | ||
| "@bbc/psammead-story-promo": "^5.1.0" |
There was a problem hiding this comment.
These dependencies are not included in package-lock.json for bulletin and Jenkins is complaining
| @@ -188,6 +188,7 @@ exports[`StoryPromo list should render correctly 1`] = ` | |||
| > | |||
| <div | |||
| class="c3" | |||
| dir="ltr" | |||
There was a problem hiding this comment.
I don't think this snapshot needs to be updated in this PR.
There was a problem hiding this comment.
It's because the top level version of story-promo in psammead was previously set to an alpha version of 4 that didn't include the dir prop. Now I've updated it, this is included in the output.
There was a problem hiding this comment.
Ah, and psammead-story-promo-list includes psammead-story-promo in tests, but not as a dev dependency.
There was a problem hiding this comment.
Or do we only have one devDependencies in the psammead root package.json?
There was a problem hiding this comment.
^ We do only include devDependencies in the root
…into update-live-label-bulletin
…into update-live-label-bulletin
package-lock.json
Outdated
| @@ -15914,14 +15906,14 @@ | |||
| }, | |||
| "aproba": { | |||
| "version": "1.2.0", | |||
| "resolved": "", | |||
| "resolved": false, | |||
There was a problem hiding this comment.
Just reverting all these
|
Why is 'close and comment' so close to 'comment'! |
Resolves bbc/simorgh#5749
Overall change:
We update the live label in story promos so we now have to explicitly state it should be aria hidden. This updates the bulletin to use this latest version.
This may not strictly be a major version change, but as I have added missing dependencies which differ by a major version to the ones currently in Simorgh, if this is a minor bump it will cause Simorgh builds to fail due to duplicate dependency versions if this is pulled in.
Code changes: