Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update typography on headline links in MostRead #3016

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Update typography on headline links in MostRead #3016

merged 4 commits into from
Jan 28, 2020

Conversation

hotinglok
Copy link
Contributor

Resolves #3015

Overall change:
Changed typography of headline links in MostRead from DoublePica to Pica for screen sizes below 400px and anything above 400 (group_2_min_width)

Code changes:

  • Changed typography in StyledLink in MostReadItem
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

Additional context
Will be just a case of taking a look with UX to see that everything is fine at each breakpoint most likely.

@hotinglok hotinglok added ws-home Tasks for the WS Home Team most-read Tasks to create Most Read component labels Jan 27, 2020
@hotinglok hotinglok added this to the Psammead 3.0 milestone Jan 27, 2020
@hotinglok hotinglok self-assigned this Jan 27, 2020
@hotinglok hotinglok changed the title Update typography on headline links in MostRead (WIP) Update typography on headline links in MostRead Jan 27, 2020
@hotinglok hotinglok changed the title (WIP) Update typography on headline links in MostRead Update typography on headline links in MostRead Jan 27, 2020
@hotinglok hotinglok marked this pull request as ready for review January 27, 2020 15:43
j-pendlebury
j-pendlebury approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs updating CHANGELOG, otherwise looks good 👍

packages/components/psammead-most-read/CHANGELOG.md Outdated Show resolved Hide resolved
@hotinglok
Update packages/components/psammead-most-read/CHANGELOG.md
0997cc8 
Co-Authored-By: Jamie Blaut <jagoda.blaut@bbc.co.uk>
OlgaLyubin
OlgaLyubin approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

sareh
sareh approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I see Pica for below 400px and Great Primer for above 400px.

@hotinglok hotinglok merged commit 70c835c into latest Jan 28, 2020
@hotinglok hotinglok deleted the MostReadFontSize branch February 11, 2020 09:55
@snyk-bot snyk-bot mentioned this pull request Feb 6, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sareh sareh sareh approved these changes

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@OlgaLyubin OlgaLyubin OlgaLyubin approved these changes

Assignees

@hotinglok hotinglok

Labels
most-read Tasks to create Most Read component ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Psammead 3.0
Development

Successfully merging this pull request may close these issues.

Change typography for headline links in MostRead & Validate UX for Burmese
4 participants
@hotinglok @sareh @j-pendlebury @OlgaLyubin