This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update text examples #2691
Merged
Update text examples #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekp
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
DenisHdz
approved these changes
Nov 26, 2019
This was referenced Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves n/a
Overall change: From my changes in this PR: #2667
I updated the data structure of services with variants to include a value for
service&variant, I also added a object for Zhongwen because I didn't notice the object forChineseexisted already in the TEXT EXAMPLE. This PR just removes theChineseexample butZhongwencovers it.Code changes: