Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix overlapping between ScriptLink and Brand #2539

Merged
10 commits merged into from
Nov 4, 2019
Merged

Fix overlapping between ScriptLink and Brand #2539

10 commits merged into from
Nov 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2019 •
edited by ghost
Loading

Resolves #2534

Overall change: Fix the overlap between ScriptLink and Brand on viewpoints < 332px.
Code changes:

  • Use flex-box to position the Brand and ScriptLink

Testing

  • Regression testing on brand.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ghost ghost added the ws-home Tasks for the WS Home Team label Nov 1, 2019
@ghost ghost self-assigned this Nov 1, 2019
@ghost ghost marked this pull request as ready for review November 1, 2019 09:00
@DenisHdz
Copy link
Contributor

DenisHdz commented Nov 1, 2019 •
edited
Loading

LGTM, just one thing. When hovering on the Brand with link, the Script Link is pushed down. Can we do something to tweak this? Or we just have to accept it since the underline makes the height bigger...

hover-bug

OlgaLyubin
OlgaLyubin approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

j-pendlebury
j-pendlebury approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jamesbrumpton jamesbrumpton self-assigned this Nov 4, 2019
@jamesbrumpton
Copy link
Contributor

lgtm

@ghost ghost merged commit 32b01e4 into latest Nov 4, 2019
@ghost ghost deleted the FixOverlappingScriptLink branch November 4, 2019 15:44
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jan 13, 2020
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@jamesbrumpton jamesbrumpton

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ScriptLink positioning in the Brand component
6 participants
@DenisHdz @jamesbrumpton @tochwill @j-pendlebury @OlgaLyubin @sadick254