This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Add scripLink prop to render ScriptLink
component
#2474
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6907262
Add scripLink prop to render `ScriptLink` component
sadick254 4fd5ebe
Update packages/components/psammead-brand/README.md
de40040
Update packages/components/psammead-brand/CHANGELOG.md
d6e1bb3
Update packages/components/psammead-brand/README.md
b9eba95
Update packages/components/psammead-brand/src/index.jsx
090f539
Merge branch 'latest' into IntegrateScriptLink
eaaad91
Merge branch 'latest' into IntegrateScriptLink
0b58073
Use flexbox instead of absolute positioning
sadick254 593ca97
Resolve conflicts
sadick254 c7c324a
Merge branch 'latest' into IntegrateScriptLink
bc2016d
Revert "Use flexbox instead of absolute positioning"
sadick254 bf87fb7
Merge branch 'latest' into IntegrateScriptLink
78fd442
Merge branch 'latest' into IntegrateScriptLink
49a951a
Merge branch 'IntegrateScriptLink' of github.com:bbc/psammead into In…
sadick254 3764d8d
Merge branch 'latest' into IntegrateScriptLink
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
top
calculation is wrong when the screen is small, making the link to go outside the banner when it should stay in it.⬇
Instead of making it absolute and calculate the top position, an alternative would be to add a new
div
to wrap both, Brand and Script Link, and use flex to align the items vertically and put them on each side. And then you wouldn't needScriptLinkWrapper
andSvgWrapper
, just to apply a couple of tweaks to theBanner
height and padding. Up to you :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DenisHdz Good point. Done 😎