This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add script boilerplate for amp js #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samora
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
dr3
reviewed
Oct 18, 2019
dr3
reviewed
Oct 18, 2019
hotinglok
reviewed
Oct 18, 2019
jroebu14
approved these changes
Oct 21, 2019
rhenshaw56
approved these changes
Oct 21, 2019
|
Tests are failing in packages/utilities/psammead-assets/index.test.jsx Psammead assets › should test all the utility exports exist and are the correct type for main Psammead assets › should test all the utility exports exist and are the correct type for module |
|
Change scanner is complaining: Branch must update CHANGELOG.md in psammead I would recommend removing your changes to the base package-lock.json as they are not changing anything useful :) |
amywalkerdev
approved these changes
Oct 23, 2019
This was referenced Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves bbc/simorgh#2156
Overall change: Add amp JS scripts boilerplate to psammead-assets. See bbc/simorgh#2156