Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

WIP - create a RTL variant of each story #2366

Closed
wants to merge 4 commits into from

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Oct 10, 2019

Resolves #1673

This will create a RTL variant of every story in storybook like this:

Screenshot 2019-10-10 at 12 18 17

Screenshot 2019-10-10 at 12 17 11

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@jroebu14 jroebu14 closed this Oct 16, 2019
@jroebu14 jroebu14 deleted the rtl-variant-all-stories branch October 16, 2019 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromatic QA checks with different storybook knob values
3 participants