Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add lang to src of media player stories #2312

Merged
merged 4 commits into from
Oct 7, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-media-player/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
| ------------- | ---------------------------------------------------------------------------------------------------------------------------- |
| 1.1.1-alpha.7 | [PR#2312](https://github.com/bbc/psammead/pull/2312) Add lang to the embed src URL in storybook examples |
| 1.1.1-alpha.6 | [PR#2297](https://github.com/bbc/psammead/pull/2297) define placeholderSrc |
| 1.1.1-alpha.5 | [PR#2280](https://github.com/bbc/psammead/pull/2280) Remove `scrolling="no"` for a11y best practice |
| 1.1.1-alpha.4 | [PR#2281](https://github.com/bbc/psammead/pull/2281) Change allowfullscreen attribute value to valid value `allowfullscreen` |
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-media-player",
"version": "1.1.1-alpha.6",
"version": "1.1.1-alpha.7",
"publishConfig": {
"tag": "alpha"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ampDecorator } from '../../../../.storybook/config';

storiesOf('Components|Media Player', module).add('default', () => (
<CanonicalMediaPlayer
src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp"
src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp/en"
placeholderSrc="https://ichef.bbci.co.uk/news/640/cpsdevpb/4eb7/test/ba7482d0-cca8-11e8-b0bf-f33155223fc4.jpg"
/>
));
Expand All @@ -15,14 +15,14 @@ storiesOf('Components|Media Player', module)
.add('AMP', () => (
<AmpMediaPlayer
isAmp
src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp/amp"
src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp/en/amp"
placeholderSrc="https://ichef.bbci.co.uk/news/640/cpsdevpb/4eb7/test/ba7482d0-cca8-11e8-b0bf-f33155223fc4.jpg"
/>
));

storiesOf('Components|Media Player', module).add('Audio Skin', () => (
<CanonicalMediaPlayer
src="https://www.test.bbc.com/ws/av-embeds/media/bbc_korean_radio/liveradio"
src="https://www.test.bbc.com/ws/av-embeds/media/bbc_korean_radio/liveradio/ko"
pjlee11 marked this conversation as resolved.
Show resolved Hide resolved
showPlaceholder={false}
skin="audio"
/>
Expand All @@ -33,7 +33,7 @@ storiesOf('Components|Media Player', module)
.add('Audio Skin AMP', () => (
<AmpMediaPlayer
isAmp
src="https://www.test.bbc.com/ws/av-embeds/media/bbc_korean_radio/liveradio/amp"
src="https://www.test.bbc.com/ws/av-embeds/media/bbc_korean_radio/liveradio/ko/amp"
pjlee11 marked this conversation as resolved.
Show resolved Hide resolved
placeholderSrc="https://news.files.bbci.co.uk/include/articles/public/images/audio-player-placeholder.png"
skin="audio"
/>
Expand Down