Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Amp validation allowfullscreen attribute #2281

Merged
merged 8 commits into from
Oct 2, 2019
Merged

Amp validation allowfullscreen attribute #2281

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c259e45
change the value of allowfullscreen to valid value
ibMadbouly Oct 1, 2019
f60b6c0
update snapshots
ibMadbouly Oct 1, 2019
87faea8
Merge branch 'latest' into amp-validation-allowfullscreen-attribute
ibMadbouly Oct 1, 2019
4d058d1
update the changelog, package.json and package-lock.json
ibMadbouly Oct 1, 2019
c194231
Merge branch 'latest' into amp-validation-allowfullscreen-attribute
ibMadbouly Oct 1, 2019
d94502e
Merge branch 'latest' into amp-validation-allowfullscreen-attribute
FK78 Oct 1, 2019
d907bb9
Merge branch 'latest' into amp-validation-allowfullscreen-attribute
ibMadbouly Oct 2, 2019
ff65a1e
merge latest and bump version after conflict
Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-media-player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 1.1.1-alpha.3 | [PR#2281](https://github.com/bbc/psammead/pull/2281) Change allowfullscreen attribute value to valid value `allowfullscreen` |
| 1.1.1-alpha.2 | [PR#2247](https://github.com/bbc/psammead/pull/2247) Update article embed URLs in MediaPLayer stories |
| 1.1.1-alpha.1 | [PR#2191](https://github.com/bbc/psammead/pull/2191) Talos - Bump Dependencies |
| 1.1.0-alpha.1 | [PR#2144](https://github.com/bbc/psammead/pull/2144) Add `skin` prop |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-media-player",
"version": "1.1.1-alpha.2",
"version": "1.1.1-alpha.3",
"publishConfig": {
"tag": "alpha"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/src/Amp/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`Media Player: Amp should render an amp-iframe with an amp-img nested in
<body>
<div>
<amp-iframe
allowfullscreen="true"
allowfullscreen="allowfullscreen"
frameborder="0"
layout="fill"
sandbox="allow-scripts allow-same-origin"
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-media-player/src/Amp/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const AmpMediaPlayer = ({ src, placeholderSrc }) => {
layout="fill"
frameborder="0"
src={src}
allowfullscreen
allowfullscreen="allowfullscreen"
>
<amp-img layout="fill" src={placeholderSrc} placeholder />
</amp-iframe>
Expand Down
6 changes: 3 additions & 3 deletions packages/components/psammead-media-player/src/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ exports[`Media Player: AMP Entry renders a landscape container with an amp-ifram
class="c0"
>
<amp-iframe
allowfullscreen="true"
allowfullscreen="allowfullscreen"
frameborder="0"
layout="fill"
sandbox="allow-scripts allow-same-origin"
Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`Media Player: AMP Entry renders a portrait container with amp-iframe an
class="c0"
>
<amp-iframe
allowfullscreen="true"
allowfullscreen="allowfullscreen"
frameborder="0"
layout="fill"
sandbox="allow-scripts allow-same-origin"
Expand Down Expand Up @@ -99,7 +99,7 @@ exports[`Media Player: AMP Entry renders the audio skin 1`] = `
class="c0"
>
<amp-iframe
allowfullscreen="true"
allowfullscreen="allowfullscreen"
frameborder="0"
layout="fill"
sandbox="allow-scripts allow-same-origin"
Expand Down