Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update Copyright badge & directory structure #187

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

bcmn
Copy link
Contributor

@bcmn bcmn commented Dec 12, 2018

Resolves #N/A

As noted on #173, there was a difference between the addition of the Copyright component & the changes to badges introduced. This wasn't addressed, so this PR is doing so.

The copyright component also didn't have source files in a src/ directory, as required. This fixes that issue. A follow-up issue will be made to ensure it's not possible to merge without enforcing this.

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@bcmn bcmn self-assigned this Dec 12, 2018
sareh
sareh previously approved these changes Dec 12, 2018
@bcmn bcmn changed the title Update Copyright PRs Welcome badge Update Copyright badge & directory structure Dec 12, 2018
ChrisBAshton
ChrisBAshton previously approved these changes Dec 12, 2018
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. Builds and tests locally.

@sareh
Copy link
Contributor

sareh commented Dec 12, 2018

Added a high priority label, since this PR is blocking any other PRs into Psammead.

@ChrisBAshton
Copy link
Contributor

In my role as standin-for-tester, I confirm I have checked out this branch, run an install and ran the tests - everything continues to pass. Happy to merge.

@ChrisBAshton ChrisBAshton merged commit 99e3a4d into latest Dec 12, 2018
@ChrisBAshton ChrisBAshton deleted the update-copyright-badge branch December 12, 2018 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants