Give more context for error output

BBC-archive · Oct 23, 2019 · d4771b7 · d4771b7
1 parent a48b94f
commit d4771b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/scripts/changeScanner/index.js b/scripts/changeScanner/index.js
@@ -18,6 +18,9 @@ Object.keys(changes).forEach(packageName => {
 
 /* eslint-disable no-console */
 if (errors.length > 0) {
+  console.error(`Please update the version number and CHANGELOG for every package that is being
+changed in this branch. The following problems were found:
+`);
   errors.forEach(error => console.error(chalk.red(error)));
   console.error(''); // empty line for spacing
   process.exit(1);

diff --git a/scripts/changeScanner/index.test.js b/scripts/changeScanner/index.test.js
@@ -69,9 +69,13 @@ describe(`changeScanner - index`, () => {
       '', // empty line for spacing
     ];
 
-    expect(consoleLogOutput).not.toHaveBeenCalled();
+    expect(consoleErrorOutput).toHaveBeenCalledTimes(
+      expectedMessages.length + 1,
+    );
 
-    expect(consoleErrorOutput).toHaveBeenCalledTimes(expectedMessages.length);
+    expect(consoleErrorOutput).toHaveBeenCalledWith(
+      expect.stringContaining('Please update the version number'),
+    );
 
     expectedMessages.forEach(msg =>
       expect(consoleErrorOutput).toHaveBeenCalledWith(msg),