Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR track2_@azure/arm-rediscache] [Go] Rename stuttering #7196

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions sdk/redis/arm-rediscache/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
# Release History

## 6.0.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes


## 6.1.0 (2022-01-21)

**Features**

- Added Interface ManagedServiceIdentity
- Added Interface UserAssignedIdentity
- Added Type Alias ManagedServiceIdentityType
- Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter preferredDataArchiveAuthMethod
- Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter preferredDataPersistenceAuthMethod
- Interface RedisCreateParameters has a new optional parameter identity
- Interface RedisUpdateParameters has a new optional parameter identity
- Type Alias RedisResource has a new parameter identity
- Added Enum KnownManagedServiceIdentityType


## 6.0.0 (2021-12-10)

The package of @azure/arm-rediscache is using our next generation design principles since version 6.0.0, which contains breaking changes.
Expand Down
2 changes: 1 addition & 1 deletion sdk/redis/arm-rediscache/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021 Microsoft
Copyright (c) 2022 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
6 changes: 3 additions & 3 deletions sdk/redis/arm-rediscache/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"commit": "76f8e0c50629ef12aa338d55782278ceca46212a",
"commit": "722d3fe61c3a072d37e929fbcb0e4e1f490ee54b",
"readme": "specification/redis/resource-manager/readme.md",
"autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/redis/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20211130.1",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/redis/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/typescript@6.0.0-alpha.16.20211130.1"
"use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
}
25 changes: 19 additions & 6 deletions sdk/redis/arm-rediscache/api-extractor.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"mainEntryPointFilePath": "./dist-esm/src/index.d.ts",
"docModel": { "enabled": true },
"apiReport": { "enabled": true, "reportFolder": "./review" },
"docModel": {
"enabled": true
},
"apiReport": {
"enabled": true,
"reportFolder": "./review"
},
"dtsRollup": {
"enabled": true,
"untrimmedFilePath": "",
"publicTrimmedFilePath": "./types/arm-rediscache.d.ts"
},
"messages": {
"tsdocMessageReporting": { "default": { "logLevel": "none" } },
"tsdocMessageReporting": {
"default": {
"logLevel": "none"
}
},
"extractorMessageReporting": {
"ae-missing-release-tag": { "logLevel": "none" },
"ae-unresolved-link": { "logLevel": "none" }
"ae-missing-release-tag": {
"logLevel": "none"
},
"ae-unresolved-link": {
"logLevel": "none"
}
}
}
}
}
7 changes: 3 additions & 4 deletions sdk/redis/arm-rediscache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for RedisManagementClient.",
"version": "6.0.1",
"version": "6.1.0",
"engines": {
"node": ">=12.0.0"
},
Expand Down Expand Up @@ -42,8 +42,7 @@
"@azure/identity": "^2.0.1",
"@azure-tools/test-recorder": "^1.0.0",
"mocha": "^7.1.1",
"cross-env": "^7.0.2",
"@azure/arm-network": "^26.0.0"
"cross-env": "^7.0.2"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/redis/arm-rediscache",
"repository": {
Expand Down Expand Up @@ -100,4 +99,4 @@
},
"sideEffects": false,
"autoPublish": true
}
}
36 changes: 36 additions & 0 deletions sdk/redis/arm-rediscache/review/arm-rediscache.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,18 @@ export enum KnownDefaultName {
Default = "default"
}

// @public
export enum KnownManagedServiceIdentityType {
// (undocumented)
None = "None",
// (undocumented)
SystemAssigned = "SystemAssigned",
// (undocumented)
SystemAssignedUserAssigned = "SystemAssigned, UserAssigned",
// (undocumented)
UserAssigned = "UserAssigned"
}

// @public
export enum KnownPrivateEndpointConnectionProvisioningState {
// (undocumented)
Expand Down Expand Up @@ -240,6 +252,19 @@ export interface LinkedServerListOptionalParams extends coreClient.OperationOpti
// @public
export type LinkedServerListResponse = RedisLinkedServerWithPropertiesList;

// @public
export interface ManagedServiceIdentity {
readonly principalId?: string;
readonly tenantId?: string;
type: ManagedServiceIdentityType;
userAssignedIdentities?: {
[propertyName: string]: UserAssignedIdentity;
};
}

// @public
export type ManagedServiceIdentityType = string;

// @public
export interface NotificationListResponse {
readonly nextLink?: string;
Expand Down Expand Up @@ -483,6 +508,8 @@ export interface RedisCommonPropertiesRedisConfiguration {
maxmemoryDelta?: string;
maxmemoryPolicy?: string;
maxmemoryReserved?: string;
readonly preferredDataArchiveAuthMethod?: string;
readonly preferredDataPersistenceAuthMethod?: string;
rdbBackupEnabled?: string;
rdbBackupFrequency?: string;
rdbBackupMaxSnapshotCount?: string;
Expand All @@ -498,6 +525,7 @@ export interface RedisCreateOptionalParams extends coreClient.OperationOptions {
// @public
export interface RedisCreateParameters {
enableNonSslPort?: boolean;
identity?: ManagedServiceIdentity;
location: string;
minimumTlsVersion?: TlsVersion;
publicNetworkAccess?: PublicNetworkAccess;
Expand Down Expand Up @@ -763,6 +791,7 @@ export type RedisRegenerateKeyResponse = RedisAccessKeys;
// @public
export type RedisResource = TrackedResource & {
zones?: string[];
identity?: ManagedServiceIdentity;
redisConfiguration?: RedisCommonPropertiesRedisConfiguration;
redisVersion?: string;
enableNonSslPort?: boolean;
Expand Down Expand Up @@ -794,6 +823,7 @@ export interface RedisUpdateOptionalParams extends coreClient.OperationOptions {
// @public
export interface RedisUpdateParameters {
enableNonSslPort?: boolean;
identity?: ManagedServiceIdentity;
minimumTlsVersion?: TlsVersion;
publicNetworkAccess?: PublicNetworkAccess;
redisConfiguration?: RedisCommonPropertiesRedisConfiguration;
Expand Down Expand Up @@ -868,6 +898,12 @@ export interface UpgradeNotification {
};
}

// @public
export interface UserAssignedIdentity {
readonly clientId?: string;
readonly principalId?: string;
}

// (No @packageDocumentation comment for this package)

```
68 changes: 68 additions & 0 deletions sdk/redis/arm-rediscache/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ export interface RedisCreateParameters {
location: string;
/** Resource tags. */
tags?: { [propertyName: string]: string };
/** The identity of the resource. */
identity?: ManagedServiceIdentity;
/** All Redis Settings. Few possible keys: rdb-backup-enabled,rdb-storage-connection-string,rdb-backup-frequency,maxmemory-delta,maxmemory-policy,notify-keyspace-events,maxmemory-samples,slowlog-log-slower-than,slowlog-max-len,list-max-ziplist-entries,list-max-ziplist-value,hash-max-ziplist-entries,hash-max-ziplist-value,set-max-intset-entries,zset-max-ziplist-entries,zset-max-ziplist-value etc. */
redisConfiguration?: RedisCommonPropertiesRedisConfiguration;
/** Redis version. Only major version will be used in PUT/PATCH request with current valid values: (4, 6) */
Expand Down Expand Up @@ -221,6 +223,48 @@ export interface RedisCommonPropertiesRedisConfiguration {
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly maxclients?: string;
/**
* Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly preferredDataArchiveAuthMethod?: string;
/**
* Preferred auth method to communicate to storage account used for data persistence, specify SAS or ManagedIdentity, default value is SAS
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly preferredDataPersistenceAuthMethod?: string;
}

/** Managed service identity (system assigned and/or user assigned identities) */
export interface ManagedServiceIdentity {
/**
* The service principal ID of the system assigned identity. This property will only be provided for a system assigned identity.
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly principalId?: string;
/**
* The tenant ID of the system assigned identity. This property will only be provided for a system assigned identity.
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly tenantId?: string;
/** Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed). */
type: ManagedServiceIdentityType;
/** The set of user assigned identities associated with the resource. The userAssignedIdentities dictionary keys will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}. The dictionary values can be empty objects ({}) in requests. */
userAssignedIdentities?: { [propertyName: string]: UserAssignedIdentity };
}

/** User assigned identity properties */
export interface UserAssignedIdentity {
/**
* The principal ID of the assigned identity.
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly principalId?: string;
/**
* The client ID of the assigned identity.
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly clientId?: string;
}

/** Redis cache access keys. */
Expand Down Expand Up @@ -322,6 +366,8 @@ export interface Resource {
export interface RedisUpdateParameters {
/** Resource tags. */
tags?: { [propertyName: string]: string };
/** The identity of the resource. */
identity?: ManagedServiceIdentity;
/** All Redis Settings. Few possible keys: rdb-backup-enabled,rdb-storage-connection-string,rdb-backup-frequency,maxmemory-delta,maxmemory-policy,notify-keyspace-events,maxmemory-samples,slowlog-log-slower-than,slowlog-max-len,list-max-ziplist-entries,list-max-ziplist-value,hash-max-ziplist-entries,hash-max-ziplist-value,set-max-intset-entries,zset-max-ziplist-entries,zset-max-ziplist-value etc. */
redisConfiguration?: RedisCommonPropertiesRedisConfiguration;
/** Redis version. Only major version will be used in PUT/PATCH request with current valid values: (4, 6) */
Expand Down Expand Up @@ -586,6 +632,8 @@ export type RedisProperties = RedisCreateProperties & {
export type RedisResource = TrackedResource & {
/** A list of availability zones denoting where the resource needs to come from. */
zones?: string[];
/** The identity of the resource. */
identity?: ManagedServiceIdentity;
/** All Redis Settings. Few possible keys: rdb-backup-enabled,rdb-storage-connection-string,rdb-backup-frequency,maxmemory-delta,maxmemory-policy,notify-keyspace-events,maxmemory-samples,slowlog-log-slower-than,slowlog-max-len,list-max-ziplist-entries,list-max-ziplist-value,hash-max-ziplist-entries,hash-max-ziplist-value,set-max-intset-entries,zset-max-ziplist-entries,zset-max-ziplist-value etc. */
redisConfiguration?: RedisCommonPropertiesRedisConfiguration;
/** Redis version. Only major version will be used in PUT/PATCH request with current valid values: (4, 6) */
Expand Down Expand Up @@ -752,6 +800,26 @@ export enum KnownPublicNetworkAccess {
*/
export type PublicNetworkAccess = string;

/** Known values of {@link ManagedServiceIdentityType} that the service accepts. */
export enum KnownManagedServiceIdentityType {
None = "None",
SystemAssigned = "SystemAssigned",
UserAssigned = "UserAssigned",
SystemAssignedUserAssigned = "SystemAssigned, UserAssigned"
}

/**
* Defines values for ManagedServiceIdentityType. \
* {@link KnownManagedServiceIdentityType} can be used interchangeably with ManagedServiceIdentityType,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **None** \
* **SystemAssigned** \
* **UserAssigned** \
* **SystemAssigned, UserAssigned**
*/
export type ManagedServiceIdentityType = string;

/** Known values of {@link ProvisioningState} that the service accepts. */
export enum KnownProvisioningState {
Creating = "Creating",
Expand Down
Loading