[AutoPR @azure/arm-links] Adding VMSS option to Force Deletion Query Parameter for Resource Group Delete #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
11 tasks
openapi-sdkautomation
bot
force-pushed
the
master
branch
from
c01f5ad
to
d87b7b2
Compare
## Bug - `receiveMessages` method returned zero messages upon a connection refresh caused by a network disconnect(simulated in the test). - `OperationTimeout` error on message settlement after the disconnect These two failures made the "disconnect" test occasionally fail for the batching receiver. ## Cause `onDetached` on the batchReceivers is called 300ms after the connection refresh causing the recovered receive link to be closed. - If the message returned from the service took close to 300ms until reached the receiver since the refresh, `onDetached` is called to close the link leading to the loss of messages. - If the 300ms had elapsed right before the settlement, we'd see the OperationTimeout error on settlement since the receive link is closed. Investigated here Azure#13339 ## Fix - Call `onDetached` for the batching receivers before calling the refresh connection - And retain calling `onDetached` for the streaming receivers after the refresh connection ## Changes in the PR - [x] Refactored "calling onDetached" part - [x] Removed the 300ms delay since we don't see the utility - [x] Changelog - [x] TODO: What to do for sessions? - [x] Needs more investigation Azure#13374 (comment), will be handled at Azure#8875
Merge 89bb404e430b977158a034f57c73ab19392ae06c into 9022265e19ebe2fa6c1955f6d99a51203897bf3d
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/12630/@azure_arm-links
branch
from
220a3ff
to
5071332
Compare
openapi-sdkautomation
bot
force-pushed
the
master
branch
from
6cda731
to
579d065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#12630
Installation Instructions
You can install the package
@azure/arm-linksof this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12630/azure-sdk-for-js/@azure_arm-links/azure-arm-links-1.0.2.tgz" -o azure-arm-links-1.0.2.tgz npm install azure-arm-links-1.0.2.tgzDirect Download
The generated package can be directly downloaded from here: