-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename WorkloadIAM to EntraWorkloadIAM #273
Rename WorkloadIAM to EntraWorkloadIAM #273
Conversation
I'm not sure what the errors in the pipeline mean, they don't seem related to this PR. |
What happens to the customer that try to use microsoft.workloadiam and the customers who have setup CI pipeline with microsoft.workloadiam? Do we show any deprecation message or a way for them to know about the name change? |
Right now we are in private preview, preparing for public preview. We know the customers that are using the extension and we are going to notify them of the change. We don't expect anyone to be using this extension in production right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any updates about when this PR will be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
02e9f06
into
AzureArcForKubernetes:k8s-extension/public
The extension type name of
microsoft.workloadiam
has been changed tomicrosoft.entraworkloadiam
. This PR updatesk8s-extension
to recognize the new name.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az k8s-extension
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.