Add WorkloadIAM extension support and tests #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioND
requested review from
NarayanThiru,
bavneetsingh16,
deeksha345 and
anagg929
as code owners
AntonioND
force-pushed
the
workload-iam
branch
from
06d01cd to
31e9431
Compare
src/k8s-extension/azext_k8s_extension/partner_extensions/WorkloadIAM.py
Outdated
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/WorkloadIAM.py
Outdated
Show resolved
Hide resolved
- Reorder imports. - User-provided configuration settings must ignore the case. However, this is only true for settings recognized by the code. Any other setting is assumed to be a Helm chart value path that needs to be left alone.
AntonioND
force-pushed
the
workload-iam
branch
from
ff4faea to
3da6fb6
Compare
NarayanThiru
approved these changes
Dec 8, 2023
NarayanThiru
merged commit 40fd25d
into
AzureArcForKubernetes:k8s-extension/public
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
microsoft.workloadiamArc extension tok8s-extensions.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.