Skip to content
This repository has been archived by the owner on Dec 30, 2018. It is now read-only.

remove unused files, make policy names configurable #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lbochenek
Copy link

@lbochenek lbochenek commented Jun 22, 2018

Removed an unused ejs file, some unused routes, and made it so policy names can be changed in config.js and those changes will be reflected in the rest of the application

@lbochenek lbochenek changed the title remove unused files, make profile names configurable remove unused files, make policy names configurable Jul 6, 2018
Copy link

@naxz naxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some minor errors when trying to run this app. There are 2 properties those names are not matching with their references in the view (views/index.ejs). Was able to run the application without problems after that.

// The names of the policies you set up in your AD B2C tenant
// Change to reflect the names you used in your AD B2C tenant
var policyNames = {
signin: 'B2C_1_signin',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Property Name

The property "signin" has to be changed to "signIn". The current name doesn't match the .ejs reference to it.

// Change to reflect the names you used in your AD B2C tenant
var policyNames = {
signin: 'B2C_1_signin',
signup: 'B2C_1_signup',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Property Name

The property "signup" has to be changed to "signUp". The current name doesn't match the .ejs reference to it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants