Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to stabilize flaky UI tests #3180

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Jan 6, 2025

Added optional retry logic for the test failures related to the client process start failures.

Addresses #3179

@kllysng kllysng requested a review from a team as a code owner January 6, 2025 21:56
@kllysng
Copy link
Contributor Author

kllysng commented Jan 6, 2025

@kllysng please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree company="Microsoft"

Copy link

github-actions bot commented Jan 6, 2025

Summary

Summary
Generated on: 1/6/2025 - 10:09:48 PM
Coverage date: 1/6/2025 - 10:08:43 PM - 1/6/2025 - 10:09:38 PM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link

github-actions bot commented Jan 6, 2025

Summary

Summary
Generated on: 1/6/2025 - 10:35:33 PM
Coverage date: 1/6/2025 - 10:34:05 PM - 1/6/2025 - 10:35:18 PM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thank you!

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to see the output.
They might be mixed-up between processes, though (not sure). Maybe have a prefix ("webApp", "webApi")

Also, I think that console.Writeline is not going to work? but it requires injecting the ITestOutputHelper?

Copy link
Contributor

@JoshLozensky JoshLozensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but otherwise looks good

Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 12:40:42 AM
Coverage date: 1/7/2025 - 12:39:30 AM - 1/7/2025 - 12:40:37 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 12:47:43 AM
Coverage date: 1/7/2025 - 12:46:19 AM - 1/7/2025 - 12:47:28 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 1:07:40 AM
Coverage date: 1/7/2025 - 1:06:32 AM - 1/7/2025 - 1:07:35 AM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@kllysng kllysng merged commit d83d251 into master Jan 7, 2025
5 checks passed
@kllysng kllysng deleted the kellysong/ui-flaky branch January 7, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants