Fix 3167 (package downgrade when referencing IdentityModel.Tokens from dev) #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
approved these changes
Dec 16, 2024
|
@jmprieur The error happened because Identity Web was the one downgrading the package (because of 5x reference) and IdentityModel was referencing the newer one? |
pmaytak
reviewed
Dec 16, 2024
…che.Memory to 6.x (because of obsolete version 5,x)
It's happening because CredentialLess exposes only netstandard2.0 -> references Microsoft.Extensions.Logging.Abstractions 2.1 through Mirosoft.IdentityModel..Tokens, but then Credentials exposes all the target frameworks, and therefore we needed to re-reference the right Microsoft.Extensions.Logging.Abstractions version per framework, do avoid the package downgrade in other assemblies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 3167 (package downgrade when referencing IdentityModel.Tokens from dev)
Removed now un-needed reference
Fixes #3167