Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scope attribute #1230

Merged
merged 2 commits into from
May 31, 2021
Merged

fix scope attribute #1230

merged 2 commits into from
May 31, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented May 31, 2021 •
edited by jmprieur
Loading

Fixes #1223 and #1036

@jennyf19 jennyf19 requested a review from jmprieur May 31, 2021 04:11
jmprieur
jmprieur approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @jennyf19

Do we also want to change the TodoListService:

  • appsettings.json to have "Scopes": "access_as_user"
  • TodoListController.cs to use [RequiredScope(RequiredScopesConfigurationKey = "AzureAd:Scopes")]

?

@jennyf19
Copy link
Collaborator Author

sounds good. done.

In reply to: 672048338

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jennyf19 jennyf19 merged commit ca22245 into master May 31, 2021
@jennyf19 jennyf19 deleted the jennyf/1223 branch May 31, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Using RequiredScope Attribute on APIController Causes 500 Response
2 participants
@jennyf19 @jmprieur