Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scope attribute from the templates for azure function #1030

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Feb 27, 2021

Updating the template as RequiredScope attribute does not work for Azure function: #1002

for reference: https://github.com/AzureAD/microsoft-identity-web/pull/946/files#diff-af09866885576871456a2ac8d0c5c4257cbaea76c0169327aa1f38ba2acdfac6L13

See also #963

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jennyf19

@jennyf19 jennyf19 merged commit 0bae831 into master Feb 27, 2021
@jennyf19 jennyf19 deleted the jennyf/fixFuncTemp branch February 27, 2021 03:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants