-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.8.0 #109
Merged
Merged
Release 0.8.0 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MSAL Python 0.7.0 back to dev branch
* [SSH] SSH support including ATs bound to keys * Fix test * Do not use casefold() * Move _validate_ssh_cert_input_data() to outer layer This at least avoids the performance penalty in those implicit loops inside acquire_token_silent(). * Code style "Don't use spaces around the = sign when used to indicate a keyword argument" - quoted from https://www.python.org/dev/peps/pep-0008/#other-recommendations * General tidy up * Move AT key_id test into its own unit test * Remove an extra space * Fix typo introduced in online editing via browser :-(
It will guide app developer to use validate_authority=False when needed.
This would become handy when we meet B2C authority with customized domain.
Interestingly, during last 10 months since this library was first released, there has been basically no customer found and asked for this feature (except only once, but that one was a red herring so he did not really want it #56 (comment) ).
Based on the way we implemented it, the previous implementation would still work, in a sense that the app dev would be guided to bypass the Instance Discovery. This commit merely adds a shortcut so that app dev would not have to explicitly toggle validate_authority=False.
Enable Python 3.8 in test automation
Customizable response_type
Per off-line discussion with @jennyf19 and @abhidnya13 , we are now merging this PR because it indeed supports B2C feature with its current API surface. The team will further discuss whether a new B2C high level API would be needed, and then we will follow up.
The more generic common endpoint can now support Device Flow for MSA
Bumping version number
abhidnya13
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the sub-PRs included in this release has been tested and reviewed and approved in their individual PR. The purpose of this all-in-one release PR is to organize the release process. Please review/proof-read the following release notes.
Release Notes:
response_type
parameter, so that your web app could use it to acquire ID Token only (Customizable response_type #105)If you prefer to, you can install this branch for your smoke testing: