-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address dependabot alerts #5503
Conversation
Codecov Report
|
@@ -12,7 +12,7 @@ | |||
"typescript": "^4.1.3" | |||
}, | |||
"devDependencies": { | |||
"@azure/identity": "^1.5.2", | |||
"@azure/identity": "^3.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big jump, any risks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glanced at the changelog and didn't see any breaking changes that would affect us. This package is used to get the test account credentials for the E2E tests so if something did break the tests on this PR would fail.
@@ -59,7 +59,7 @@ | |||
}, | |||
"dependencies": { | |||
"@azure/msal-common": "^9.0.1", | |||
"jsonwebtoken": "^8.5.1", | |||
"jsonwebtoken": "^9.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When are you planning on making a release with this change for @azure/msal-node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be released on Monday, January 9th. Thanks for your patience!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be released on Monday, January 9th. Thanks for your patience!
are you sure? That linked PR just got renamed to the February
release rather than January
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We release on the first Monday of every month, since yesterday was a holiday we've pushed it to the 9th. Ignore the release PR name, it's automated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, @tnorling. I do not see any new release on the npm registry today. There is a new planned date for publishing the new version? Thank you very much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franher we'll be starting the release in a couple of hours :)
Addresses a number of dependabot alerts