Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed authority issue #452

Merged
merged 2 commits into from
Oct 22, 2018
Merged

fixed authority issue #452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
134d60a
fixed authority issue
rohitnarula7176 Oct 8, 2018
2278385
Merge branch 'dev' into ronaru/Issue_347
nehaagrawal Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/msal-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@angular/platform-browser-dynamic": "~4.3.0",
"@angular/router": "^4.3.0",
"@types/handlebars": "4.0.33",
"@types/jasmine": "^2.8.6",
"@types/jasmine": "2.5.38",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should upgrade to @types/jasmine": "2.5.41",instead of 2.5.38 as per this github issue DefinitelyTyped/DefinitelyTyped#14569. I have created a separate PR to fix this issue. Please revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same link has the version 2.5.38 listed as well which worked for other users. I don't think it matters which version to use as long as the doc issue is fixed. If you want , you can change the version later on after merging this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a higher version fixes the issue we shouldn't downgrade too much. I have fixed it in a different PR and merge changes to this PR.

"@types/jasmine-ajax": "^3.1.35",
"angular-router-loader": "^0.8.5",
"angular2-template-loader": "^0.6.2",
Expand Down
121 changes: 55 additions & 66 deletions lib/msal-core/dist/msal.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions lib/msal-core/dist/msal.min.js
View file
Open in desktop

Large diffs are not rendered by default.

865 changes: 0 additions & 865 deletions lib/msal-core/docs/assets/css/main.css
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions lib/msal-core/docs/assets/css/main.css.map
View file
Open in desktop

This file was deleted.

Binary file removed lib/msal-core/docs/assets/images/icons.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/msal-core/docs/assets/images/icons@2x.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/msal-core/docs/assets/images/widgets.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/msal-core/docs/assets/images/widgets@2x.png
View file
Open in desktop
Binary file not shown.
5 changes: 0 additions & 5 deletions lib/msal-core/docs/assets/js/main.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions lib/msal-core/docs/assets/js/search.js
View file
Open in desktop

This file was deleted.

324 changes: 0 additions & 324 deletions lib/msal-core/docs/classes/_accesstokencacheitem_.accesstokencacheitem.html
View file
Open in desktop

This file was deleted.

361 changes: 0 additions & 361 deletions lib/msal-core/docs/classes/_accesstokenkey_.accesstokenkey.html
View file
Open in desktop

This file was deleted.

381 changes: 0 additions & 381 deletions lib/msal-core/docs/classes/_accesstokenvalue_.accesstokenvalue.html
View file
Open in desktop

This file was deleted.

649 changes: 0 additions & 649 deletions ...-core/docs/classes/_authenticationrequestparameters_.authenticationrequestparameters.html
View file
Open in desktop

This file was deleted.

665 changes: 0 additions & 665 deletions lib/msal-core/docs/classes/_authority_.authority.html
View file
Open in desktop

This file was deleted.

315 changes: 0 additions & 315 deletions lib/msal-core/docs/classes/_authorityfactory_.authorityfactory.html
View file
Open in desktop

This file was deleted.

602 changes: 0 additions & 602 deletions lib/msal-core/docs/classes/_b2cauthority_.b2cauthority.html
View file
Open in desktop

This file was deleted.

401 changes: 0 additions & 401 deletions lib/msal-core/docs/classes/_clientinfo_.clientinfo.html
View file
Open in desktop

This file was deleted.

1,443 changes: 0 additions & 1,443 deletions lib/msal-core/docs/classes/_constants_.constants.html
View file
Open in desktop

This file was deleted.

411 changes: 0 additions & 411 deletions lib/msal-core/docs/classes/_constants_.errorcodes.html
View file
Open in desktop

This file was deleted.

411 changes: 0 additions & 411 deletions lib/msal-core/docs/classes/_constants_.errordescription.html
View file
Open in desktop

This file was deleted.

363 changes: 0 additions & 363 deletions lib/msal-core/docs/classes/_errormessage_.errormessage.html
View file
Open in desktop

This file was deleted.

475 changes: 0 additions & 475 deletions lib/msal-core/docs/classes/_idtoken_.idtoken.html
View file
Open in desktop

This file was deleted.

673 changes: 0 additions & 673 deletions lib/msal-core/docs/classes/_logger_.logger.html
View file
Open in desktop

This file was deleted.

380 changes: 0 additions & 380 deletions lib/msal-core/docs/classes/_requestinfo_.tokenresponse.html
View file
Open in desktop

This file was deleted.

657 changes: 0 additions & 657 deletions lib/msal-core/docs/classes/_storage_.storage.html
View file
Open in desktop

This file was deleted.

433 changes: 0 additions & 433 deletions lib/msal-core/docs/classes/_user_.user.html
View file
Open in desktop

This file was deleted.

2,277 changes: 0 additions & 2,277 deletions lib/msal-core/docs/classes/_useragentapplication_.useragentapplication.html
View file
Open in desktop

This file was deleted.

966 changes: 0 additions & 966 deletions lib/msal-core/docs/classes/_utils_.utils.html
View file
Open in desktop

This file was deleted.

341 changes: 0 additions & 341 deletions lib/msal-core/docs/classes/_xhrclient_.xhrclient.html
View file
Open in desktop

This file was deleted.

318 changes: 0 additions & 318 deletions lib/msal-core/docs/enums/_authority_.authoritytype.html
View file
Open in desktop

This file was deleted.

312 changes: 0 additions & 312 deletions lib/msal-core/docs/enums/_logger_.loglevel.html
View file
Open in desktop

This file was deleted.

Loading