Update UserAgentApplication.ts #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashot999
approved these changes
Jun 12, 2018
ilovepixelart
approved these changes
Jun 12, 2018
CristianKhalilSC
approved these changes
Jun 12, 2018
|
@nehaagrawal Can you please review this pull request? We are facing issues on production because of this bug. Thanks |
|
@aoeah done. |
|
Thanks guys for the quick response! |
|
Yes I'd love to know as well, causing us issues in prod. Thank you very much for working on this and getting it merged :) |
|
@ashot999 @dougmolineux This was released in 0.1.7 https://github.com/AzureAD/microsoft-authentication-library-for-js/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the issue in #300
Resolving an issue where if the msal library is initiated from a browser window that linked via a target=_blank it will throw an error. Instead of touching the window.opener.msal yet again, this will just utilize the already evaluated isWindowOpenerMsal variable set above.
To repro the issue prior to this change, you just need a page which is utilizing the msal library to handle a signup or sign-in. Then, create a secondary html page which links to the page that then has a target=_blank which will then open another tab. The end result is that the library will throw an exception and rendering is halted (assuming no error handling is being leveraged).