Remove isAngular flags for handling redirects #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Jan 12, 2020
|
@sameerag Yeah, not touching any of the other usage, for now. |
sameerag
approved these changes
Jan 13, 2020
|
It is already removed in the work for v2. I'll make further removals for v1 as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSAL Angular
0.1.4, the processing of redirect responses happen in the Angular wrapper itself. For the next version of MSAL Angular library, we want the core library to handle that, so we need to remove these checks.Cherry-picked from #1160