Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting applied to most files #417

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Conversation

Avery-Dunn
Copy link
Collaborator

@Avery-Dunn Avery-Dunn commented Jul 12, 2021

Inspired by #416 and #410, I applied IntelliJ's default code formatting to all files, and most received at least some small change.

The majority of the changes are simple whitespace fixes : adding/removing spaces, newlines, tabs, etc. There were a couple actual code changes, but it was just replacing the hardcoded string "UTF-8" with the value from Java's StandardCharsets file (see AccountTest for an example), and simplifying a couple of if statements (see InteractionRequiredCache)

@Avery-Dunn Avery-Dunn requested review from SomkaPe and sangonzal July 12, 2021 22:01
@cbismuth
Copy link

cbismuth commented Jul 24, 2021

Would be great to make this configuration local to your IntelliJ project and then commit a subset of configuration files, so that code style would be consistent across contributors using IntelliJ.

To do so create a .gitignore file in your .idea/ directory and add these lines:

*

!.gitignore

!codeStyles/
!codeStyles/*.xml

!inspectionProfiles/
!inspectionProfiles/*.xml

!runConfigurations/
!runConfigurations/*.xml

Here is a sample project.

@Avery-Dunn Avery-Dunn merged commit 773f2d9 into dev Jul 26, 2021
Avery-Dunn added a commit that referenced this pull request Jan 27, 2022
* Allow empty set for scopes. Remove empty string if included in scopes for silent request

* Trim scopes

* Minor code formatting applied to most files (#417)

* Initial commit

* Remove info flagged by automated build step (#440)

* Remove info flagged by automated build step

* Remove unneeded references and test for old Azure Germany cloud

* Issue #437 fix - Drop validation on subject and issuer values

* Fixed tests

* Created new app to fix failing tests

* Moving tests to an existing file

* Adding copyright line

* Adding comments

* Bump version numbers for 1.11.1 release (#460)

Co-authored-by: Santiago Gonzalez <sagonzal@microsoft.com>
Co-authored-by: Santiago Gonzalez <35743865+sangonzal@users.noreply.github.com>
Co-authored-by: siddhijain <siddhijain@microsoft.com>
Co-authored-by: siddhijain <siddhi0811@gmail.com>
@siddhijain siddhijain deleted the avdunn/code-formatting branch June 29, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants