WithTenantId on CIAM authorities
#4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Jul 6, 2023
pmaytak
reviewed
Jul 8, 2023
src/client/Microsoft.Identity.Client/ApiConfig/SystemWebViewOptions.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/AuthorityInfo.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/AuthorityInfo.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The method comment for AbstractApplicationBuilder.WithTenantId needs to be updated to match the one here to clarify that WithTenantId overwrites the authority tenant.
tests/Microsoft.Identity.Test.Unit/ApiConfigTests/AuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ApiConfigTests/AuthorityTests.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Jul 11, 2023
|
@pmaytak - no need to re-review, I pressed the button by mistake :) |
pmaytak
approved these changes
Jul 20, 2023
trwalke
reviewed
Jul 21, 2023
trwalke
reviewed
Jul 21, 2023
trwalke
reviewed
Jul 21, 2023
tests/Microsoft.Identity.Test.Unit/ApiConfigTests/AuthorityTests.cs
Outdated
Show resolved
Hide resolved
trwalke
reviewed
Jul 21, 2023
tests/Microsoft.Identity.Test.Unit/ApiConfigTests/AuthorityTests.cs
Outdated
Show resolved
Hide resolved
trwalke
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4191