Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] MSAL should not stop developers from adding reserved scopes #1422

Closed
bgavrilMS opened this issue Oct 8, 2019 · 2 comments
Closed

[Bug] MSAL should not stop developers from adding reserved scopes #1422

bgavrilMS opened this issue Oct 8, 2019 · 2 comments
Assignees
@bgavrilMS
Labels
bug Supportability
Milestone
4.5

Comments

@bgavrilMS
Copy link
Member

Which Version of MSAL are you using ?
MSAL 4.4

Platform
all

What authentication flow has the issue?
Client Credentials and all others.

Actual: MSAL throws a client exception stating that users should not add their own reserved scope "openid"
Expected: MSAL should not throw, instead it should just merge scopes
@bgavrilMS
Copy link
Member Author

CC @jmprieur

@bgavrilMS bgavrilMS self-assigned this Oct 8, 2019
@bgavrilMS bgavrilMS added this to the 4.4.1 milestone Oct 8, 2019
bgavrilMS added a commit that referenced this issue Oct 8, 2019
@bgavrilMS
Fix #1422 - handle protected scopes better
293f0f6
@bgavrilMS bgavrilMS mentioned this issue Oct 8, 2019
Merged
@jennyf19 jennyf19 modified the milestones: 4.4.1, 4.5 Oct 9, 2019
@jennyf19 jennyf19 added Fixed and removed In Progress labels Oct 9, 2019
@bgavrilMS bgavrilMS reopened this Oct 11, 2019
@jennyf19
Copy link
Collaborator

This is included in the 4.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgavrilMS bgavrilMS

Labels
bug Supportability
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
3 participants
@bgavrilMS @jmprieur @jennyf19