Migrate Base64 away from Msebera (in Android), Fixes AB#3077784 #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3077784 to an Azure Boards work item. |
github-actions
bot
changed the title
fadidurah
approved these changes
Oct 30, 2024
melissaahn
approved these changes
Nov 1, 2024
somalaya
pushed a commit
that referenced
this pull request
Dec 26, 2024
Update and enable tests to run in pipeline (#2199) Enabling 2 FLW test cases, which have been disabled to run in pipeline. TestCase833513 - Updated account type and error verification TestCase833515 - Replaced Edge steps with Outlook TestCase1592468 - Removed as this is not valid Ran locally with latest RC builds to verify these are passing. Quick fix to ignore those flaky tests. Will be resolved later. (#2205) Take new common, some ui fixes, Fixes AB#3058394 (#2198) changes: - Combined https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2516613 into https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2516571, test will attempt sign in with just outlook, then AuthApp + outlook, finally install cp then able to sign in. Also covers https://identitydivision.visualstudio.com/Engineering/_workitems/edit/831545 because just tests auth with outlook and CP. - Adjustments to TestCase2516967 for consistency - Take common changes [AB#3058394](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3058394) Add Account Manager Tests, enable reading local flights param in automation apps, Fixes AB#3026183 (#2207) Add Account Manager Tests, enable reading local flights param in automation apps [AB#3026183](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3026183) Migrate URIBuilder to httpcore5, Fixes AB#2909378 (#2203) Part 1 of the work to get rid msebera.httpclient. [AB#2909378](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2909378) Migrate the usage of uribuilder to httpcore5 Update Native Auth E2E tests to use more reliable inbox code retrieval method, Fixes AB#3037823 (#2211) The original PR: #2189 Work Item: [AB#3037823](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3037823) --------- Co-authored-by: Robert McCahill <rmccahill@microsoft.com> Adding more MSA test configs to MsalTestApp (#2209) This PR adds two more config options for MsalTestApp: - WEBVIEW_MSA: Webview selected as auth agent; Allows for MSA and AAD accounts; passkeys enabled - WEBVIEW_PPE_MSA: Webview selected as auth agent; INT MSA and PPE AAD accounts; passkeys enabled Migrate Base64 away from Msebera (in Android), Fixes AB#3077784 (#2210) [AB#3077784](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3077784) merge release/5.8.0 to dev (#2217) Remove email attribute, Fixes AB#3080769 (#2224) Remove "email" from the UserAttribute class. The email address is passed as "username" in the signUp process. Bug item description: https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3080769 [AB#3080769](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3080769) Merging Somalaya/release/5.8.2 to dev (#2223) Co-authored-by: iamgusain <75644120+iamgusain@users.noreply.github.com> Android E2E Sign Up, Fixes AB#3073857 (#2213) Create a draft version instead of an official one: #2212 because the PR is still in the draft version. [AB#3073857](https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3073857) Android Test plan: https://identitydivision.visualstudio.com/Engineering/_testPlans/define?planId=3054662&suiteId=3054727 2.1.5 2.1.6 2.1.7 (out of scopes for the Lab environment, include them once the environment is ready) 2.1.8 2.1.9 2.1.10 2.1.11 1.1.2 1.1.5 1.1.10 1.1.11 1.1.12 1.1.13 1.1.14 Add suberror for network errors, Fixes AB#3064171 (#2218) Related: AzureAD/microsoft-authentication-library-common-for-android#2537 Also make sure that MsalClientException returns the sub error code. [AB#3064171](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3064171) automation app name changes automation app name changes automation app name changes automation app name changes tests with oneAuthTestApp updated use lab query instead of temp user removed temp user rebased and removed unnecessary code updated common ignore unnecessary test retry on failure ignored unnecessary test retry added removed retry removed duplicate retry bringing back erroneously deleted file
somalaya
pushed a commit
that referenced
this pull request
Dec 26, 2024
Update and enable tests to run in pipeline (#2199) Enabling 2 FLW test cases, which have been disabled to run in pipeline. TestCase833513 - Updated account type and error verification TestCase833515 - Replaced Edge steps with Outlook TestCase1592468 - Removed as this is not valid Ran locally with latest RC builds to verify these are passing. Quick fix to ignore those flaky tests. Will be resolved later. (#2205) Take new common, some ui fixes, Fixes AB#3058394 (#2198) changes: - Combined https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2516613 into https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2516571, test will attempt sign in with just outlook, then AuthApp + outlook, finally install cp then able to sign in. Also covers https://identitydivision.visualstudio.com/Engineering/_workitems/edit/831545 because just tests auth with outlook and CP. - Adjustments to TestCase2516967 for consistency - Take common changes [AB#3058394](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3058394) Add Account Manager Tests, enable reading local flights param in automation apps, Fixes AB#3026183 (#2207) Add Account Manager Tests, enable reading local flights param in automation apps [AB#3026183](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3026183) Migrate URIBuilder to httpcore5, Fixes AB#2909378 (#2203) Part 1 of the work to get rid msebera.httpclient. [AB#2909378](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2909378) Migrate the usage of uribuilder to httpcore5 Update Native Auth E2E tests to use more reliable inbox code retrieval method, Fixes AB#3037823 (#2211) The original PR: #2189 Work Item: [AB#3037823](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3037823) --------- Co-authored-by: Robert McCahill <rmccahill@microsoft.com> Adding more MSA test configs to MsalTestApp (#2209) This PR adds two more config options for MsalTestApp: - WEBVIEW_MSA: Webview selected as auth agent; Allows for MSA and AAD accounts; passkeys enabled - WEBVIEW_PPE_MSA: Webview selected as auth agent; INT MSA and PPE AAD accounts; passkeys enabled Migrate Base64 away from Msebera (in Android), Fixes AB#3077784 (#2210) [AB#3077784](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3077784) merge release/5.8.0 to dev (#2217) Remove email attribute, Fixes AB#3080769 (#2224) Remove "email" from the UserAttribute class. The email address is passed as "username" in the signUp process. Bug item description: https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3080769 [AB#3080769](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3080769) Merging Somalaya/release/5.8.2 to dev (#2223) Co-authored-by: iamgusain <75644120+iamgusain@users.noreply.github.com> Android E2E Sign Up, Fixes AB#3073857 (#2213) Create a draft version instead of an official one: #2212 because the PR is still in the draft version. [AB#3073857](https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3073857) Android Test plan: https://identitydivision.visualstudio.com/Engineering/_testPlans/define?planId=3054662&suiteId=3054727 2.1.5 2.1.6 2.1.7 (out of scopes for the Lab environment, include them once the environment is ready) 2.1.8 2.1.9 2.1.10 2.1.11 1.1.2 1.1.5 1.1.10 1.1.11 1.1.12 1.1.13 1.1.14 Add suberror for network errors, Fixes AB#3064171 (#2218) Related: AzureAD/microsoft-authentication-library-common-for-android#2537 Also make sure that MsalClientException returns the sub error code. [AB#3064171](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3064171) automation app name changes automation app name changes automation app name changes automation app name changes tests with oneAuthTestApp updated use lab query instead of temp user removed temp user rebased and removed unnecessary code updated common ignore unnecessary test retry on failure ignored unnecessary test retry added removed retry removed duplicate retry bringing back erroneously deleted file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3077784