Adding null checks and logging to filter methods in AccountAdapter #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@melissaahn is this taking our pr (#1927) and using it as an issue report? |
No, I am referring to a separate issue reported internally. I wasn't aware of your team's PR initially, so I will link your PR in the description of this one to show that your team has also noted this issue. |
somalaya
reviewed
Oct 24, 2023
msal/src/main/java/com/microsoft/identity/client/AccountAdapter.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 24, 2023
msal/src/main/java/com/microsoft/identity/client/AccountAdapter.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 24, 2023
msal/src/main/java/com/microsoft/identity/client/AccountAdapter.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 24, 2023
msal/src/main/java/com/microsoft/identity/client/AccountAdapter.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Oct 24, 2023
shahzaibj
reviewed
Oct 24, 2023
shahzaibj
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an incident opened up that reported some crashes for devices in SDM due to a NPE thrown within the AccountAdapter class.
This PR adds handling and logging for any NPE errors thrown in the filter methods. Note that this is not a root cause fix for the incident, but will provide a mitigation.
Update: We also received a PR from a customer who noted they are also seeing crash reports due to the same NPE: #1927
Related PR