Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(prod) Fix for account id missing in msal get account #1558

Merged
merged 7 commits into from
Jan 5, 2022
Merged

(prod) Fix for account id missing in msal get account #1558

merged 7 commits into from
Jan 5, 2022

Conversation

shahzaibj
Copy link
Contributor

@shahzaibj shahzaibj commented Nov 23, 2021 •
edited
Loading

@github-actions github-actions bot added the msal label Nov 23, 2021
@shahzaibj shahzaibj mentioned this pull request Jan 3, 2022
Merged
@shahzaibj shahzaibj changed the title Fix for account id missing in msal get account (prod) Fix for account id missing in msal get account Jan 3, 2022
@shahzaibj shahzaibj changed the base branch from master to release/2.2.3 January 5, 2022 18:58
@shahzaibj shahzaibj marked this pull request as ready for review January 5, 2022 19:02
@shahzaibj shahzaibj requested review from rpdome, shoatman and a team January 5, 2022 19:33
AdamBJohnsonx
AdamBJohnsonx approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@AdamBJohnsonx AdamBJohnsonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really creating a null-value-object to avoid the crash.

@shahzaibj shahzaibj merged commit 393529c into release/2.2.3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBJohnsonx AdamBJohnsonx AdamBJohnsonx approved these changes

@rpdome rpdome Awaiting requested review from rpdome

@shoatman shoatman Awaiting requested review from shoatman

Assignees
No one assigned
Labels
msal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahzaibj @AdamBJohnsonx