-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MSAL dependencies to 4.59.1 #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to see many of our dependency versions converging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as my question is non-blocking--just something to keep in mind as we merge.
Thanks for adding a detailed description, @Haard30! Super helpful! |
Upgrading MSAL version to
4.59.1
Why not the latest
4.60.3
?There are few unresolved issues in 4.60.x version of MSAL for example:
[Bug] Broker-based flows fail for MSA accounts with latest MSAL.
Also, looking at the changelog, there does not seem to be an immediate need to move to
4.60.x
, hence updating to a more stable version for now.Selected improvements and bug fixes which can be helpful:
4.59.0
-• Fixed a scenario when the same tokens are cached under different cache keys when an identity provider sends scopes in a different order.
• Fixed SemaphoreFullException happening in managed identity flows.
4.58.1
-• Fixed an issue with sending an incorrect operating system descriptor in silent flows on Mac.
• Added WithForceRefresh support for silent flows using the Windows broker.
4.57
-• Included missing Windows broker-related exception data when serializing MSAL exceptions.
• Added additional logging in the cache.
4.56
-• Added AuthenticationResult.AuthenticationResultMetadata.Telemetry that currently contains telemetry from the Windows broker (WAM).
• Added clarity to the Windows broker logs.
Upgrading microsoft-authentication-extensions-for-dotnet
Testing
Benchmark test
4.59.1
4.55.0
Other
Tested following commands on both mac and windows: