Skip to content
This repository has been archived by the owner on Jun 26, 2021. It is now read-only.

Update prompt param if it's already provided in the url (fix fo #636) #645

Closed
wants to merge 2 commits into from

Conversation

tamerlan
Copy link

Extracted the function to add parameter to the url. It should prevent duplicated params to appear.

@msftclas
Copy link

msftclas commented Oct 25, 2017

CLA assistant check
All CLA requirements met.

@rohitnarula7176
Copy link
Contributor

@tamerlan @tamerlan Thank you for your contribution. We cannot accept this pull request because your code allows the developers to overwrite the value for prompt in acquireToken methods which we cannot allow by design as it happens in a hidden iframe where prompt cannot be anything other than none. I have made the code change in dev branch such that if you pass prompt value through extraQueryParameter, it will only get added to the login method of adal which is the only one that does not specify prompt value by default. The recommended value for prompt is 'select_account' for login.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants