Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0303 release #36

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

elenavillamil
Copy link
Collaborator

Releasing latest CLI for bridge.

Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think along with GH issues we can add small description to it ex: Newston to STJ conversion, Named Port Support. It will be helpful for everyone.

@elenavillamil
Copy link
Collaborator Author

LGTM, I think along with GH issues we can add small description to it ex: Newston to STJ conversion, Named Port Support. It will be helpful for everyone.

Good idea, updated :)

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡🥷🎊 Thank you so much and addition to the review, this specific PR looks good, but Important thing to note is that I don't see how do we identify formal b2k cli release because this latest expectedCLI is not part of the B2K Changelog "1.0.20230310.3", wonder why?

💡☕️ Thinking outlaud - Let's close open bug and change the changelog et. al. at b2k cli repo level and then release this.

Thanks heaps,

CHANGELOG.md Show resolved Hide resolved
@elenavillamil
Copy link
Collaborator Author

💡🥷🎊 Thank you so much and addition to the review, this specific PR looks good, but Important thing to note is that I don't see how do we identify formal b2k cli release because this latest expectedCLI is not part of the B2K Changelog "1.0.20230310.3", wonder why?

💡☕️ Thinking outlaud - Let's close open bug and change the changelog et. al. at b2k cli repo level and then release this.

Thanks heaps,

Ah yes we need to get in the habit of updating b2k change log. Let me send PR for that. I wont check it in until release goes through since it wont be "officially" released until we fully release.

@elenavillamil elenavillamil merged commit fb28174 into Azure:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants