Fix vulnerabilities and update packages. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2022
Closed
Tatsinnit
force-pushed
the
fix/packages-audit
branch
from
184f763 to
6f97d9e
Compare
Tatsinnit
force-pushed
the
fix/packages-audit
branch
from
6f97d9e to
4d19674
Compare
hsubramanianaks
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Hi Tats, Left some minor comments. Thank you for this PR.
FYI resource I found for tslint --> eslint conversion, https://github.com/typescript-eslint/tslint-to-eslint-config. I am not sure if this is the best resource. Just added here for reference. Thanks again.
Thank you so much ❤️❤️🙏☕️ @hsubramanianaks yep, hence if you see the PR it adds
Also for rest I have made apt info et. al. , thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage of holiday work and hence opening this PR as one for all PR and avoid 1-1 PRs opened by bots which could cause issues because of the way individually they update, especially these runs are based on
packages-lock.jsonwhich also contains dependent packages which are not taken into consideration while bot scans the file.Following PR also take care of few packages which are are deprecated, or really old and no development has happened around them for last 4 years.
usecolorsunder this PR : Remove deprecated methods mochajs/mocha#4178Rest of the changes are fairly dependent on the audit and errors. We do need proper testing for this, to record all the functionality working around this.
Thanks heaps! ❤️☕️🙏