Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-response-body rule is triggering for some standard templates #1740

Merged
merged 28 commits into from
Nov 26, 2024
Merged

no-response-body rule is triggering for some standard templates #1740

merged 28 commits into from
Nov 26, 2024

Conversation

AlitzelMendez
Copy link
Member

issue: #1552

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 24, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
  • ✅ @azure-tools/typespec-azure-rulesets
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Update the arm no-response-body rule to behave similarly to the core rule, but with the additional requirement that the 202 response can and should also be empty

@azure-tools/typespec-azure-rulesets - feature ✏️

Update the arm no-response-body rule to behave similarly to the core rule, but with the additional requirement that the 202 response can and should also be empty

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez marked this pull request as ready for review October 25, 2024 18:03
markcowl
markcowl requested changes Oct 30, 2024
View reviewed changes
docs/libraries/azure-resource-manager/rules/no-response-body.md Outdated Show resolved Hide resolved
docs/libraries/azure-resource-manager/rules/no-response-body.md Outdated Show resolved Hide resolved
docs/libraries/azure-resource-manager/rules/no-response-body.md Outdated Show resolved Hide resolved
docs/libraries/azure-resource-manager/rules/no-response-body.md Outdated Show resolved Hide resolved
docs/libraries/azure-resource-manager/rules/no-response-body.md Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/src/rules/utils.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/test/rules/no-response-body.test.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/test/rules/no-response-body.test.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/test/rules/no-response-body.test.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/test/rules/no-response-body.test.ts Outdated Show resolved Hide resolved
@AlitzelMendez AlitzelMendez linked an issue Oct 31, 2024 that may be closed by this pull request
no-response-body rule is triggering for some standard templates #1552
Closed
AlitzelMendez and others added 11 commits October 31, 2024 14:51
@AlitzelMendez
Feedback:
65df221 
- Update documentation to reflect arm usage
- Use isAzureSubNamespace from azure.core instead of adding a new one on arm
- Update test to use arm examples
- Names updates to
@AlitzelMendez @markcowl
Update docs/libraries/azure-resource-manager/rules/no-response-body.md
f2aaec1 
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
@AlitzelMendez @markcowl
Update docs/libraries/azure-resource-manager/rules/no-response-body.md
ea57a0e 
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
@AlitzelMendez
Add summary of changes
759893a
@AlitzelMendez
Merge branch 'no-response-body-rule' of https://github.com/AlitzelMen…
82e2545 
…dez/typespec-azure into no-response-body-rule
@AlitzelMendez
Feedback: Removing condition, still pending fixing samples
65a0c34
@AlitzelMendez
resolving merge conflicts
74ac522
@AlitzelMendez
rule condition should match ARM scenarios
167c8b6
@AlitzelMendez
Merge branch 'main' into no-response-body-rule
2e0994c
@AlitzelMendez
feedback
5f66a18
@AlitzelMendez
Merge branch 'no-response-body-rule' of https://github.com/AlitzelMen…
bab649a 
…dez/typespec-azure into no-response-body-rule
@AlitzelMendez AlitzelMendez mentioned this pull request Nov 18, 2024
Closed
@AlitzelMendez
Copy link
Member Author

validation result: https://github.com/Azure/azure-rest-api-specs/actions/runs/11902850879

@markcowl markcowl self-assigned this Nov 21, 2024
AlitzelMendez and others added 3 commits November 26, 2024 11:48
@AlitzelMendez @markcowl
Update packages/typespec-azure-resource-manager/src/rules/no-response…
423aa9f 
…-body.ts

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
@AlitzelMendez @markcowl
Update packages/typespec-azure-resource-manager/src/rules/no-response…
0d66e23 
…-body.ts

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
@AlitzelMendez
Tess feedback
17de8e7
@markcowl markcowl enabled auto-merge November 26, 2024 20:07
@markcowl markcowl added this pull request to the merge queue Nov 26, 2024
Merged via the queue into Azure:main with commit f970ef1 Nov 26, 2024
23 checks passed
markcowl added a commit to markcowl/typespec-azure that referenced this pull request Dec 5, 2024
@AlitzelMendez @markcowl
no-response-body rule is triggering for some standard templates (Azur…
670e2c6 
…e#1740)

issue: Azure#1552

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@markcowl markcowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-response-body rule is triggering for some standard templates
3 participants
@AlitzelMendez @azure-sdk @markcowl