Uptake Enum-driven visibility (#1829)

This PR is for validation of the uptake of microsoft/typespec#4825 It masks some no-deprecated lint errors that result from the deprecation of `getVisibility` --------- Co-authored-by: Will Temple <will@wtemple.net>
Azure · Nov 8, 2024 · f9689c4 · f9689c4
1 parent d0d9485
commit f9689c4
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 1 deletion.
diff --git a/.chronus/changes/witemple-msft-visibility-enum-2024-10-7-17-47-11.md b/.chronus/changes/witemple-msft-visibility-enum-2024-10-7-17-47-11.md
@@ -0,0 +1,10 @@
+---
+changeKind: internal
+packages:
+  - "@azure-tools/typespec-autorest"
+  - "@azure-tools/typespec-azure-core"
+  - "@azure-tools/typespec-azure-resource-manager"
+  - "@azure-tools/typespec-client-generator-core"
+---
+
+Mask deprecation lint warnings for uptake of enum-driven visibility.
diff --git a/core b/core
diff --git a/packages/typespec-autorest/src/openapi.ts b/packages/typespec-autorest/src/openapi.ts
@@ -1986,6 +1986,7 @@ export async function getOpenAPIForService(
       if (isReadonlyProperty(program, prop)) {
         property.readOnly = true;
       } else {
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         const vis = getVisibility(program, prop);
         if (vis) {
           const mutability = [];
@@ -2038,6 +2039,7 @@ export async function getOpenAPIForService(
 
   function canSharePropertyUsingReadonlyOrXMSMutability(prop: ModelProperty) {
     const sharedVisibilities = ["read", "create", "update", "write"];
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
     const visibilities = getVisibility(program, prop);
     if (visibilities) {
       for (const visibility of visibilities) {

diff --git a/packages/typespec-autorest/src/utils.ts b/packages/typespec-autorest/src/utils.ts
@@ -103,6 +103,7 @@ export function resolveOperationId(context: AutorestEmitterContext, operation: O
  * designate a read-only property.
  */
 export function isReadonlyProperty(program: Program, property: ModelProperty) {
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   const visibility = getVisibility(program, property);
   // note: multiple visibilities that include read are not handled using
   // readonly: true, but using separate schemas.

diff --git a/packages/typespec-azure-core/src/rules/require-key-visibility.ts b/packages/typespec-azure-core/src/rules/require-key-visibility.ts
@@ -18,6 +18,7 @@ export const requireKeyVisibility = createRule({
           model.name !== "object"
         ) {
           for (const [name, prop] of model.properties) {
+            // eslint-disable-next-line @typescript-eslint/no-deprecated
             if (isKey(context.program, prop) && !getVisibility(context.program, prop)) {
               context.reportDiagnostic({
                 target: prop,

diff --git a/packages/typespec-azure-resource-manager/src/rules/arm-resource-provisioning-state-rule.ts b/packages/typespec-azure-resource-manager/src/rules/arm-resource-provisioning-state-rule.ts
@@ -108,6 +108,7 @@ export const armResourceProvisioningStateRule = createRule({
           }
 
           // validate it must has a read only visibility
+          // eslint-disable-next-line @typescript-eslint/no-deprecated
           const visibilities = getVisibility(context.program, provisioning);
           if (
             !(visibilities !== undefined && visibilities.length === 1 && visibilities[0] === "read")

diff --git a/packages/typespec-azure-resource-manager/src/rules/resource-name.ts b/packages/typespec-azure-resource-manager/src/rules/resource-name.ts
@@ -44,6 +44,7 @@ export const resourceNameRule = createRule({
         }
 
         function checkResourceName(nameProp: ModelProperty) {
+          // eslint-disable-next-line @typescript-eslint/no-deprecated
           const visibilities = getVisibility(context.program, nameProp);
           return (
             !http.isPathParam(context.program, nameProp) ||

diff --git a/packages/typespec-client-generator-core/src/types.ts b/packages/typespec-client-generator-core/src/types.ts
@@ -1036,6 +1036,7 @@ export function isReadOnly(property: SdkBodyModelPropertyType) {
 }
 
 function getSdkVisibility(context: TCGCContext, type: ModelProperty): Visibility[] | undefined {
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   const visibility = getVisibility(context.program, type);
   if (visibility) {
     const result: Visibility[] = [];