[tcgc] remove filtering core model flag (#1806)

fix: #1803 --------- Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Azure · Nov 5, 2024 · 6b7cd4d · 6b7cd4d
1 parent 5c9a6d0
commit 6b7cd4d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/.chronus/changes/remove_flag-2024-10-5-18-43-3.md b/.chronus/changes/remove_flag-2024-10-5-18-43-3.md
@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@azure-tools/typespec-client-generator-core"
+---
+
+remove filtering core model flag
diff --git a/packages/typespec-client-generator-core/src/interfaces.ts b/packages/typespec-client-generator-core/src/interfaces.ts
@@ -66,7 +66,6 @@ export interface SdkContext<
 export interface SdkEmitterOptions {
   "generate-protocol-methods"?: boolean;
   "generate-convenience-methods"?: boolean;
-  "filter-out-core-models"?: boolean;
   "package-name"?: string;
   "flatten-union-as-enum"?: boolean;
   "api-version"?: string;

diff --git a/packages/typespec-client-generator-core/test/methods/lro.test.ts b/packages/typespec-client-generator-core/test/methods/lro.test.ts
@@ -15,7 +15,6 @@ describe("typespec-client-generator-core: long running operation metadata", () =
       runner = await createSdkTestRunner({
         librariesToAdd: [AzureCoreTestLibrary],
         autoUsings: ["Azure.Core", "Azure.Core.Traits"],
-        "filter-out-core-models": false, // need to check some Azure.Core models
       });
       const baseCompile = runner.compile;
       runner.compileWithVersionedService = async function (code) {
@@ -379,7 +378,6 @@ describe("typespec-client-generator-core: long running operation metadata", () =
       runner = await createSdkTestRunner({
         librariesToAdd: [AzureCoreTestLibrary, AzureResourceManagerTestLibrary, OpenAPITestLibrary],
         autoUsings: ["Azure.Core", "Azure.Core.Traits", "Azure.ResourceManager"],
-        "filter-out-core-models": false, // need to check some Azure.Core models
       });
       const baseCompile = runner.compile;
       runner.compileWithVersionedService = async function (code) {

diff --git a/packages/typespec-client-generator-core/test/types/array-types.test.ts b/packages/typespec-client-generator-core/test/types/array-types.test.ts
@@ -52,7 +52,6 @@ describe("typespec-client-generator-core: array types", () => {
     runner = await createSdkTestRunner({
       librariesToAdd: [AzureCoreTestLibrary],
       autoUsings: ["Azure.Core"],
-      "filter-out-core-models": false,
       emitterName: "@azure-tools/typespec-java",
     });
     await runner.compileWithBuiltInAzureCoreService(`
@@ -79,7 +78,6 @@ describe("typespec-client-generator-core: array types", () => {
     runner = await createSdkTestRunner({
       librariesToAdd: [AzureCoreTestLibrary],
       autoUsings: ["Azure.Core"],
-      "filter-out-core-models": false,
       emitterName: "@azure-tools/typespec-java",
     });
     await runner.compileWithBuiltInAzureCoreService(`

diff --git a/packages/typespec-client-generator-core/test/types/built-in-types.test.ts b/packages/typespec-client-generator-core/test/types/built-in-types.test.ts
@@ -268,7 +268,6 @@ describe("typespec-client-generator-core: built-in types", () => {
     runner = await createSdkTestRunner({
       librariesToAdd: [AzureCoreTestLibrary],
       autoUsings: ["Azure.Core"],
-      "filter-out-core-models": false,
       emitterName: "@azure-tools/typespec-java",
     });
     await runner.compileWithBuiltInAzureCoreService(`

diff --git a/packages/typespec-client-generator-core/test/types/model-types.test.ts b/packages/typespec-client-generator-core/test/types/model-types.test.ts
@@ -720,7 +720,6 @@ describe("typespec-client-generator-core: model types", () => {
     runner = await createSdkTestRunner({
       librariesToAdd: [AzureCoreTestLibrary],
       autoUsings: ["Azure.Core"],
-      "filter-out-core-models": false,
       emitterName: "@azure-tools/typespec-java",
     });
     await runner.compileWithBuiltInAzureCoreService(`
@@ -784,7 +783,6 @@ describe("typespec-client-generator-core: model types", () => {
     runner = await createSdkTestRunner({
       librariesToAdd: [AzureCoreTestLibrary],
       autoUsings: ["Azure.Core"],
-      "filter-out-core-models": false,
       emitterName: "@azure-tools/typespec-java",
     });
     await runner.compileWithBuiltInAzureCoreService(`