fix(retry): add WithMaxElapsedTime to retry options and refactor to use functional options #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaredfholgate discovered an issue with long resource operations and retry.
The package we use has a default max elapsed time of 15m.
This causes an issue when the resource's
timeoutvalues were set to longer than 15m.This PR adds the
backoff.WithMaxElapsedTime()setting into the retry configuration. It sets this to the resource's timeout value. Since we use the context aware retry function in the backoff package this value just needs to be equal to or higher than the timeout value. Once the context deadline is exceeded then the retry package will exit anyway (we already have unit tests for this).I have also refactored to remove the unnecessary
NewRetryableErrors()function from the clients package. This was inflexible and using the functional options variadic pattern provided by the backoff package is much cleaner.To support the conversion of
[]stringto[]regexpI have added a small function.WDYT @ms-henglu ?